Re: libata total system lockup fix

[Mark Lord <liml@rtr.ca>]

 >The problem with this patch is that is causes leaks, and doesn't actually ready the devices because scsi_eh_ready_devs() is never called: scsi_eh_abort_cmds() is guaranteed to fail out every time its called.

MMmm.. bummer if that's the case, but it does execute here
on my machine about once every two seconds, continuously,
for hours on end, and the DVD-RW drive still works when
I eventually do place a disc into it later on.

I suppose the bug isn't seen more commonly because libata is
the only (?) SCSI LLD that supplies it's own eh strategy function.
Or are there other users of that interface now?

I'm off on holiday for the next while, but I'll check in on this
again when I get back.  Perhaps the originator of this patch could
chip in with some of the fixes, if you point out where the "leaks" are.

 >Ahha.. here's the header from the original email for this patch
 >Subject: [PATCH] Fix SATA ATAPI error handling
 >From: Hannes Reinecke <hare@suse.de>
 >Date: Wed, 23 Mar 2005 16:28:16 +0100
 >To: SCSI Mailing List <linux-scsi@vger.kernel.org>
 >CC: linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
 >Jens Axboe <axboe@suse.de>, Kurt Garloff <garloff@suse.de>:

Cheers