From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: axboe@suse.de, linux-ide@vger.kernel.org
Subject: Re: [PATCH Linux 2.6.12 07/09] NCQ: stop dma before reset
Date: Tue, 26 Jul 2005 17:12:42 -0400 [thread overview]
Message-ID: <42E6A74A.80709@pobox.com> (raw)
In-Reply-To: <20050626152105.F3C5D2FC@htj.dyndns.org>
Tejun Heo wrote:
> 07_NCQ_ahci-stop-dma-before-reset.patch
>
> AHCI 1.1 mandates stopping dma before issueing COMMRESET. The
> original code didn't and it resulted in occasional lockup of
> the controller during EH recovery. This patch fixes the
> problem.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> ahci.c | 2 ++
> 1 files changed, 2 insertions(+)
>
> Index: work/drivers/scsi/ahci.c
> ===================================================================
> --- work.orig/drivers/scsi/ahci.c 2005-06-27 00:20:31.000000000 +0900
> +++ work/drivers/scsi/ahci.c 2005-06-27 00:20:31.000000000 +0900
> @@ -474,7 +474,9 @@ static void ahci_phy_reset(struct ata_po
> struct ata_device *dev = &ap->device[0];
> u32 tmp;
>
> + ahci_stop_dma(ap);
> __sata_phy_reset(ap);
> + ahci_start_dma(ap);
This is a bit worrisome, because we really shouldn't be calling
ahci_phy_reset() when DMA is -not- stopped. That's a violation of the
state machine.
Jeff
next prev parent reply other threads:[~2005-07-26 21:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 15:21 [PATCH Linux 2.6.12 00/09] NCQ: generic NCQ completion/error-handling Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 01/09] NCQ: add ata_qc_complete_err() and @drv_err to functions Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 02/09] NCQ: add timeout to ata_read_log_page() Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 03/09] NCQ: add ap->sactive Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 04/09] NCQ: export scsi_retry_command Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 05/09] NCQ: implement NCQ helpers Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 06/09] NCQ: convert ahci to use new " Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 07/09] NCQ: stop dma before reset Tejun Heo
2005-07-26 21:12 ` Jeff Garzik [this message]
2005-07-27 6:25 ` Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 08/09] NCQ: remove/unexport unused/unnecessary functions Tejun Heo
2005-06-26 15:21 ` [PATCH Linux 2.6.12 09/09] NCQ: causes error or timeout Tejun Heo
2005-06-26 15:34 ` test logs Tejun Heo
2005-06-27 14:33 ` [PATCH Linux 2.6.12 00/09] NCQ: generic NCQ completion/error-handling Jens Axboe
2005-06-30 7:36 ` Jens Axboe
2005-06-30 10:51 ` Tejun Heo
2005-06-30 15:26 ` Jens Axboe
2005-07-01 0:20 ` Tejun
2005-07-01 8:59 ` Jens Axboe
2005-07-04 5:53 ` Jens Axboe
2005-07-06 12:55 ` Jens Axboe
2005-07-06 13:00 ` Jens Axboe
2005-07-06 15:11 ` Tejun Heo
2005-07-08 8:03 ` Jens Axboe
2005-07-08 10:27 ` Tejun Heo
2005-07-08 13:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42E6A74A.80709@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).