From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: [git patch] libata fix Date: Sun, 31 Jul 2005 19:29:23 -0400 Message-ID: <42ED5ED3.9060209@pobox.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000002090103040500040007" Return-path: Received: from mail.dvmed.net ([216.237.124.58]:17371 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S262081AbVGaX30 (ORCPT ); Sun, 31 Jul 2005 19:29:26 -0400 Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Linus Torvalds , Andrew Morton Cc: "linux-ide@vger.kernel.org" , Linux Kernel This is a multi-part message in MIME format. --------------000002090103040500040007 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Please pull from the 'upstream-fixes' branch of rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git to obtain the damnable-annoying[1] fix described in the attached diffstat/changelog/patch. Jeff [1] the option is truly a boolean, that enables or disables a menu (not any code). But it won't work as a boolean apparently :/ Roman doesn't have any better suggestions, so oh well. --------------000002090103040500040007 Content-Type: text/plain; name="libata-dev.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="libata-dev.txt" drivers/scsi/Kconfig | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) commit faa725332f39329288f52b7f872ffda866ba5b09 Author: Adrian Bunk Date: Wed Jul 27 01:06:35 2005 -0700 [PATCH] SCSI_SATA has to be a tristate SCSI=m must disallow static drivers. The problem is that all the SATA drivers depend on SCSI_SATA. With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA drivers with unwanted effects, e.g.: - SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y -> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked into the kernel - SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m -> SCSI_ATA_ADMA and libata are built statically but scsi/built-in.o is not linked into the kernel, SCSI_SATA_AHCI is built modular (unresolved symbols due to missing libata) Signed-off-by: Adrian Bunk Cc: Jeff Garzik Signed-off-by: Andrew Morton Signed-off-by: Jeff Garzik diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -424,7 +424,7 @@ config SCSI_IN2000 source "drivers/scsi/megaraid/Kconfig.megaraid" config SCSI_SATA - bool "Serial ATA (SATA) support" + tristate "Serial ATA (SATA) support" depends on SCSI help This driver family supports Serial ATA host controllers --------------000002090103040500040007--