From: Jeff Garzik <jgarzik@pobox.com>
To: Albert Lee <albertcc@tw.ibm.com>
Cc: IDE Linux <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2/3] libata ata_data_xfer() fix
Date: Mon, 01 Aug 2005 14:36:51 -0400 [thread overview]
Message-ID: <42EE6BC3.1040401@pobox.com> (raw)
In-Reply-To: <42EE392B.8000405@tw.ibm.com>
Albert Lee wrote:
> Jeff,
>
> PATCH 2/3: ata_data_xfer() fix
>
> Changes:
> - Add ATA_FLAG_IO_32BIT to libata.h for hosts with 32-bit data register.
> - Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer
> length
> not aligned to 32-bit boundary.
>
> This patch does not reuse ap->pad as alignment buffer since
> four bytes of local variable seems good enough.
32-bit IO needs to be a separate patch.
I made a design decision to -not- support 32bit IO, since it is not
universally supported by all host controllers. It is much easier to say
"use DMA" instead.
libata would need additional checks, following similar logic in
drivers/ide, to do 32-bit IO.
Jeff
next prev parent reply other threads:[~2005-08-01 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 14:54 [PATCH 0/3] libata PIO fixes (revised) Albert Lee
2005-08-01 14:57 ` [PATCH 1/3] libata "if condition" enhancement Albert Lee
2005-08-01 15:00 ` [PATCH 2/3] libata ata_data_xfer() fix Albert Lee
2005-08-01 18:36 ` Jeff Garzik [this message]
2005-08-01 15:03 ` [PATCH 3/3] libata handle the case when device returns/needs extra data Albert Lee
2005-08-01 18:37 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EE6BC3.1040401@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).