From: Edward Falk <efalk@google.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Carlos Pardo <Carlos.Pardo@siliconimage.com>
Subject: Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver
Date: Thu, 04 Aug 2005 11:46:51 -0700 [thread overview]
Message-ID: <42F2629B.70407@google.com> (raw)
In-Reply-To: <20050804022025.GA19237@htj.dyndns.org>
> I agree that above code should clear both. Just wanna verify. Have
> you tested it and/or do you have any information confirming this? If
> we don't have any further info, I think we should read PORT_SLOT_STAT
> before clearing PORT_IRQ_STAT to be on the safe side.
I've implemented the clear_irq() function to clear all interrupts as you
said, but haven't had time to test this thoroughly. Ultimately, we
don't know if it works until we experience real errors and see how the
system responds.
I don't think it matters in which order you do things, as long as you
allow for the fact that reading PORT_SLOT_STAT will clear the command
completion interrupt flag.
-ed
next prev parent reply other threads:[~2005-08-04 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 1:36 [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver Tejun Heo
2005-07-28 20:27 ` Jeff Garzik
2005-07-30 8:17 ` Tejun Heo
2005-08-02 22:56 ` Edward Falk
2005-08-03 4:09 ` Jeff Garzik
2005-08-03 14:28 ` Tejun Heo
2005-08-04 2:20 ` Tejun Heo
2005-08-04 18:46 ` Edward Falk [this message]
2005-08-04 8:51 ` Tejun Heo
2005-08-04 18:51 ` Edward Falk
2005-08-05 2:30 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2005-08-08 17:31 Carlos Pardo
2005-08-08 17:37 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F2629B.70407@google.com \
--to=efalk@google.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).