linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: James Courtier-Dutton <James@superbug.demon.co.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: libata for SATA HDs.
Date: Tue, 09 Aug 2005 22:28:04 -0400	[thread overview]
Message-ID: <42F96634.6040308@rtr.ca> (raw)
In-Reply-To: <42F92DE7.9070301@superbug.demon.co.uk>

>>>> Yes, but only if you manually apply the "libata-passthru" patch.
>>>
>>> So, why hasn't that patch got into the kernel?
>>
>> Because there are several reports of it causing problems, when used on a
>> loaded system.

Please post more information about these "problems".

I wonder if it might be another occurance of the libata eh lockups.
Those are NOT unique to ATAPI -- the lockups can happen anytime
the libata eh code is run, like on a busy RAID, or "loaded system"
suffering failed "passthru" commands.

Perhaps kill a couple of birds with one stone, if we're lucky.

So far, the one-liner from Tejun Heo (below) is holding steady here,
but it needs to soak for another day before I pronounce it "cured".

Cheers!


diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -385,6 +385,7 @@ int ata_scsi_error(struct Scsi_Host *hos
          * appropriate place
          */
         host->host_failed--;
+       INIT_LIST_HEAD(&host->eh_cmd_q);

         DPRINTK("EXIT\n");
         return 0;

  reply	other threads:[~2005-08-10  2:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <42EEA9D5.5080304@superbug.demon.co.uk>
2005-08-09 13:40 ` libata for SATA HDs Mark Lord
2005-08-09 17:01   ` Erik Slagter
2005-08-09 17:55   ` James Courtier-Dutton
2005-08-09 18:04     ` Jeff Garzik
2005-08-09 22:27       ` James Courtier-Dutton
2005-08-10  2:28         ` Mark Lord [this message]
2005-08-09 18:18   ` Erik Slagter
2005-08-09 20:04     ` Mark Lord
2005-08-10  7:41       ` Erik Slagter
2005-08-10 18:42 Timothy Thelin
2005-08-11  3:21 ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2005-08-12  1:04 Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42F96634.6040308@rtr.ca \
    --to=liml@rtr.ca \
    --cc=James@superbug.demon.co.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).