From: Jeff Garzik <jgarzik@pobox.com>
To: Brett Russ <russb@emc.com>
Cc: Albert Lee <albertcc@tw.ibm.com>,
Linux IDE <linux-ide@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Doug Maxey <dwm@maxeymade.com>
Subject: Re: [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO
Date: Wed, 10 Aug 2005 22:37:36 -0400 [thread overview]
Message-ID: <42FAB9F0.9080103@pobox.com> (raw)
In-Reply-To: <42F26F1F.8010903@emc.com>
Brett Russ wrote:
> Albert Lee wrote:
>
>> + cgcr = readl(port_mmio(ap, PDC_GLOBAL_CTL));
>
>
> I've read that read[bwl]() and write[bwl]() are deprecated and
> discouraged in new code and instead ioread{8,16,32}() and
> iowrite{8,16,32}() should be used. Is this the case?
ioread/write should only be used when the code in question may have to
use either readl() or inl().
When a driver is written for hardware that is -always- used in MMIO
mode, then readl() is preferred, since its faster.
Jeff
next prev parent reply other threads:[~2005-08-11 2:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 17:17 [PATCH 0/3] libata-dev: pdc2027x fixes Albert Lee
2005-08-04 17:32 ` [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO Albert Lee
2005-08-04 19:40 ` Brett Russ
2005-08-09 11:04 ` Albert Lee
2005-08-11 2:37 ` Jeff Garzik [this message]
2005-08-11 3:03 ` Jeff Garzik
2005-08-11 9:49 ` Albert Lee
2005-08-11 17:49 ` Jeff Garzik
2005-08-04 17:34 ` [PATCH 2/3] libata-dev: pdc2027x mdelay() problem fix for power5 micro-partitioning Albert Lee
2005-08-07 9:18 ` Benjamin Herrenschmidt
2005-08-11 3:04 ` Jeff Garzik
2005-08-11 8:36 ` Benjamin Herrenschmidt
2005-08-11 9:52 ` Albert Lee
2005-08-04 17:39 ` [PATCH 3/3] libata-dev: Fix pdc2027x ATAPI DMA lost irq problem Albert Lee
2005-08-04 18:41 ` Doug Maxey
2005-08-11 3:05 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2005-08-12 7:09 [PATCH 0/3] libata-dev: pdc2027x fixes Albert Lee
2005-08-12 7:19 ` [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FAB9F0.9080103@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=dwm@maxeymade.com \
--cc=linux-ide@vger.kernel.org \
--cc=russb@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).