From: Jeff Garzik <jgarzik@pobox.com>
To: Edward Falk <efalk@google.com>
Cc: linux-ide@vger.kernel.org, linux-kernel-daily-digest@lists.us.dell.com
Subject: Re: [PATCH] Lay groundwork for ATA port multiplier support
Date: Wed, 10 Aug 2005 23:27:30 -0400 [thread overview]
Message-ID: <42FAC5A2.4000507@pobox.com> (raw)
In-Reply-To: <42F7F352.2080307@google.com>
Edward Falk wrote:
> This patch adds a few constants related to port multipliers to libata.h,
> hdreg.h, and libata-core.c
In addition to my previous comment ("ata.h not hdreg.h"), grep for
ATA_DEV_ATA and ATA_DEV_ATAPI in the code.
There are a few cases where you see code like
if (class == ATA_DEV_ATA)
...
else
...
which assume that only found, identified devices make it to that point
in the code; ATA_DEV_NONE/UNKNOWN are guaranteed not to occur in that
code path simply due to other code rules.
Jeff
prev parent reply other threads:[~2005-08-11 3:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-09 0:05 [PATCH] Lay groundwork for ATA port multiplier support Edward Falk
2005-08-09 2:22 ` Jeff Garzik
2005-08-11 3:27 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FAC5A2.4000507@pobox.com \
--to=jgarzik@pobox.com \
--cc=efalk@google.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel-daily-digest@lists.us.dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).