From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Carlos.Pardo@siliconimage.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-dev-2.6:sil24 02/07] sil24: move error handling out of hot interrupt path
Date: Thu, 11 Aug 2005 15:18:05 -0400 [thread overview]
Message-ID: <42FBA46D.7040504@pobox.com> (raw)
In-Reply-To: <20050730101344.F56FB4A0@htj.dyndns.org>
Tejun Heo wrote:
> 02_sil24_separate-out-error-path.patch
>
> Move error handling from sil24_host_intr into separate
> function - sil24_error_intr.
>
> Jeff, I don't think this patch actually improves readability
> and/or performance. Is this what you wanted?
Yes.
It improves readability and maintainability by clearly separating the
error and non-error paths.
It improves performance by removing an uncommon path -- error -- from
the hot path (command completion).
Jeff
next prev parent reply other threads:[~2005-08-11 19:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-30 10:13 [PATCH libata-dev-2.6:sil24 00/07] sil24: misc fixes Tejun Heo
2005-07-30 10:13 ` [PATCH libata-dev-2.6:sil24 01/07] sil24: implement status register emulation Tejun Heo
2005-08-11 19:18 ` Jeff Garzik
2005-07-30 10:14 ` [PATCH libata-dev-2.6:sil24 02/07] sil24: move error handling out of hot interrupt path Tejun Heo
2005-08-11 19:18 ` Jeff Garzik [this message]
2005-07-30 10:14 ` [PATCH libata-dev-2.6:sil24 03/07] sil24: add testing for PCI fault Tejun Heo
2005-08-11 19:19 ` Jeff Garzik
2005-07-30 10:14 ` [PATCH libata-dev-2.6:sil24 04/07] sil24: remove irq disable code on spurious interrupt Tejun Heo
2005-08-11 19:19 ` Jeff Garzik
2005-07-30 10:14 ` [PATCH libata-dev-2.6:sil24 05/07] sil24: use longer delay function and less iteration in reset_controller Tejun Heo
2005-08-11 19:20 ` Jeff Garzik
2005-08-12 0:54 ` Tejun Heo
2005-07-30 10:14 ` [PATCH libata-dev-2.6:sil24 06/07] sil24: add IO flushing after masking irq during initialization Tejun Heo
2005-08-11 19:20 ` Jeff Garzik
2005-07-30 10:14 ` [PATCH libata-dev-2.6:sil24 07/07] sil24: add FIXME comment above ata_device_add Tejun Heo
2005-08-11 19:21 ` Jeff Garzik
2005-08-11 19:21 ` [PATCH libata-dev-2.6:sil24 00/07] sil24: misc fixes Jeff Garzik
2005-08-12 0:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FBA46D.7040504@pobox.com \
--to=jgarzik@pobox.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).