From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE Linux <linux-ide@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Doug Maxey <dwm@maxeymade.com>
Subject: Re: [PATCH 0/3] libata-dev: pdc2027x fixes
Date: Fri, 12 Aug 2005 16:10:08 +0800 [thread overview]
Message-ID: <42FC5960.3030703@tw.ibm.com> (raw)
In-Reply-To: <42FC51BB.2050401@pobox.com>
Jeff,
> Albert Lee wrote:
>
>> Jeff,
>>
>> pdc2027x driver fix:
>>
>> 1/3 pdc1.diff:
>> - Convert pdc2027x from PIO to MMIO.
>>
>> 2/3 pdc2.diff:
>> - use "long" for the counter data type instead of "unsigned long"
>>
>> 3/3 pdc3.diff:
>> - pdc2027x ATAPI DMA irq lost problem workaround
>
>
> Applied all three patches to pdc2027x branch of libata-dev.git.
>
> I continue to dislike patch #3, but without more info, I fear this
> workaround may be necessary.
>
I've visited Promise in February for the pdc2027x irq lost problem.
They said it might be related to hardware FIFO problem, but they also
said it might be ATAPI device problem. I don't know how to fix it, just
have the (buflen% 256) workaround by trial and error. The (buflen % 256)
workaround does not alway work, however.
After checking how the ATAPI DMA is handled in their GPL code last week,
I sent an e-mail to ask them about the workaround, especially the
strange negative LBA check. No reply yet.
The command white list workaround alone seems working fine so far. Read,
burn and rip audio tracks by ATAPI DMA are ok. If any WRITE_10 problem
is hit in the future, maybe we can try the negative LBA check then.
Thanks for the review,
Albert
next prev parent reply other threads:[~2005-08-12 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 7:09 [PATCH 0/3] libata-dev: pdc2027x fixes Albert Lee
2005-08-12 7:19 ` [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO Albert Lee
2005-08-12 7:21 ` [PATCH 2/3] libata-dev: pdc2027x use "long" for counter data type Albert Lee
2005-08-12 7:23 ` [PATCH 3/3] libata-dev: pdc2027x ATAPI DMA lost irq problem workaround Albert Lee
2005-08-12 7:41 ` Jeff Garzik
2005-08-12 8:20 ` Albert Lee
2005-08-12 7:37 ` [PATCH 0/3] libata-dev: pdc2027x fixes Jeff Garzik
2005-08-12 8:10 ` Albert Lee [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-08-04 17:17 Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FC5960.3030703@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=dwm@maxeymade.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).