From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: stable@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-sata: fix ata_scsi_lpm_supported() iteration
Date: Wed, 29 Jul 2026 10:49:13 +0900 [thread overview]
Message-ID: <42d66aa3-e996-487f-a44f-ad3d1fd8be69@kernel.org> (raw)
In-Reply-To: <20260728113841.727256-2-cassel@kernel.org>
On 7/28/26 20:38, Niklas Cassel wrote:
> The inner loop of ata_scsi_lpm_supported() user the wrong variable when
> iterating.
>
> It should obviously use the link that we are currently iterating over,
> rather than always using the host link.
>
> ata_scsi_lpm_supported() is used to control if a user should be allowed
> to change lpm policy (from the default) via sysfs.
>
> Thus, this bug could potentially disallow users to change the LPM policy
> for certain SATA devices via sysfs.
>
> Cc: stable@vger.kernel.org
> Fixes: 0060beec0bfa ("ata: libata-sata: Add link_power_management_supported sysfs attribute")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://lore.kernel.org/linux-ide/20260728112200.B99F21F000E9@smtp.kernel.org/
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Applied to for-7.2-fixes, with the message typo fixed. Thanks!
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-07-29 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:38 [PATCH] ata: libata-sata: fix ata_scsi_lpm_supported() iteration Niklas Cassel
2026-07-28 11:40 ` Niklas Cassel
2026-07-28 11:53 ` sashiko-bot
2026-07-28 12:16 ` Niklas Cassel
2026-07-28 12:37 ` Niklas Cassel
2026-07-29 1:49 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42d66aa3-e996-487f-a44f-ad3d1fd8be69@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox