From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI
Date: Thu, 8 Jan 2026 16:32:51 +0100 [thread overview]
Message-ID: <42ea9b9a-e34a-401a-a083-daf08442a92c@kernel.org> (raw)
In-Reply-To: <aV_DqvnmcjoTXPKr@ryzen>
On 1/8/26 15:48, Niklas Cassel wrote:
> On Thu, Jan 08, 2026 at 03:12:34PM +0100, Niklas Cassel wrote:
>> Commit b1f5af54f1f5 ("ata: libata-core: Advertize device support for DIPM
>> and HIPM features") added prints if the device supports DIPM and HIPM,
>> however, it forgot to update the same print for ATAPI devices.
>>
>> Before changes:
>> ata1.00: ATAPI: Slimtype DVD A DU8AESH, 6C2M, max UDMA/133
>>
>> After changes:
>> ata1.00: ATAPI: Slimtype DVD A DU8AESH, 6C2M, max UDMA/133 HIPM DIPM
>>
>> Signed-off-by: Niklas Cassel <cassel@kernel.org>
>
> Don't merge this.
> I think I have a nicer way.
Yeah. Adding a different "Features" message like we have for ATA and ZAC devices
would be better.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-01-08 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 14:12 [PATCH] ata: libata: Advertize device support for DIPM and HIPM features for ATAPI Niklas Cassel
2026-01-08 14:48 ` Niklas Cassel
2026-01-08 15:32 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ea9b9a-e34a-401a-a083-daf08442a92c@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox