From: Mika Kukkonen <mikukkon@gmail.com>
To: B.Zolnierkiewicz@elka.pw.edu.pl
Cc: linux-ide@vger.kernel.org, hannal@us.ibm.com
Subject: Small compile fix to ide.c with !CONFIG_PCI
Date: Thu, 10 Feb 2005 10:17:50 +0200 [thread overview]
Message-ID: <4301cff605021000172ead5f0c@mail.gmail.com> (raw)
Hi!
Small patch to fix following warning with CONFIG_IDE && !CONFIG_PCI:
CC drivers/ide/ide.o
drivers/ide/ide.c: In function 'ide_system_bus_speed':
drivers/ide/ide.c:338: warning: unused variable 'pci_default'
I decided to save some bytes by #ifdef:ing the struct in question.
CC:ing Hanna because she did the change (and just to say hi ;-).
--MiKu
Signed-off-by: Mika Kukkonen <mikukkon@gmail.com>
--- linux-tiny/drivers/ide/ide.c 2005-02-10 09:47:08.000000000 +0200
+++ linux-2.5/drivers/ide/ide.c 2005-02-10 09:45:34.000000000 +0200
@@ -335,10 +335,14 @@ static void __init init_ide_data (void)
static int ide_system_bus_speed(void)
{
+#ifdef CONFIG_PCI
static struct pci_device_id pci_default[] = {
{ PCI_DEVICE(PCI_ANY_ID, PCI_ANY_ID) },
{ }
};
+#else
+#define pci_default 0
+#endif /* CONFIG_PCI */
if (!system_bus_speed) {
if (idebus_parameter) {
next reply other threads:[~2005-02-10 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 8:17 Mika Kukkonen [this message]
2005-02-20 11:46 ` Small compile fix to ide.c with !CONFIG_PCI Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4301cff605021000172ead5f0c@mail.gmail.com \
--to=mikukkon@gmail.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=hannal@us.ibm.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).