linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Small compile fix to ide.c with !CONFIG_PCI
@ 2005-02-10  8:17 Mika Kukkonen
  2005-02-20 11:46 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Mika Kukkonen @ 2005-02-10  8:17 UTC (permalink / raw)
  To: B.Zolnierkiewicz; +Cc: linux-ide, hannal

Hi!

Small patch to fix following warning with CONFIG_IDE && !CONFIG_PCI:

  CC	drivers/ide/ide.o
drivers/ide/ide.c: In function 'ide_system_bus_speed':
drivers/ide/ide.c:338: warning: unused variable 'pci_default'

I decided to save some bytes by #ifdef:ing the struct in question.
CC:ing Hanna because she did the change (and just to say hi ;-).

--MiKu

Signed-off-by: Mika Kukkonen <mikukkon@gmail.com>

--- linux-tiny/drivers/ide/ide.c	2005-02-10 09:47:08.000000000 +0200
+++ linux-2.5/drivers/ide/ide.c 2005-02-10 09:45:34.000000000 +0200
@@ -335,10 +335,14 @@ static void __init init_ide_data (void)

 static int ide_system_bus_speed(void)
 {
+#ifdef CONFIG_PCI
	static struct pci_device_id pci_default[] = {
		{ PCI_DEVICE(PCI_ANY_ID, PCI_ANY_ID) },
		{ }
	};
+#else
+#define pci_default 0
+#endif /* CONFIG_PCI */

	if (!system_bus_speed) {
		if (idebus_parameter) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Small compile fix to ide.c with !CONFIG_PCI
  2005-02-10  8:17 Small compile fix to ide.c with !CONFIG_PCI Mika Kukkonen
@ 2005-02-20 11:46 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-20 11:46 UTC (permalink / raw)
  To: Mika Kukkonen; +Cc: linux-ide, hannal

applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-20 11:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-10  8:17 Small compile fix to ide.c with !CONFIG_PCI Mika Kukkonen
2005-02-20 11:46 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).