* ata_scsi_queuecmd locking question @ 2005-08-16 22:21 Jim Ramsay 2005-08-16 22:35 ` Jeff Garzik 0 siblings, 1 reply; 3+ messages in thread From: Jim Ramsay @ 2005-08-16 22:21 UTC (permalink / raw) To: Linux-ide I'm just looking into libata-scsi.c, and noticed that the comments for ata_scs_queuecmd note that it is supposed to obtain host_set->lock. It doesn't seem to do so. Should it? -- Jim Ramsay "Me fail English? That's unpossible!" ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ata_scsi_queuecmd locking question 2005-08-16 22:21 ata_scsi_queuecmd locking question Jim Ramsay @ 2005-08-16 22:35 ` Jeff Garzik 2005-08-17 15:23 ` Jim Ramsay 0 siblings, 1 reply; 3+ messages in thread From: Jeff Garzik @ 2005-08-16 22:35 UTC (permalink / raw) To: Jim Ramsay; +Cc: Linux-ide Jim Ramsay wrote: > I'm just looking into libata-scsi.c, and noticed that the comments for > ata_scs_queuecmd note that it is supposed to obtain host_set->lock. > It doesn't seem to do so. > > Should it? The SCSI layer acquires this lock for us. Jeff ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ata_scsi_queuecmd locking question 2005-08-16 22:35 ` Jeff Garzik @ 2005-08-17 15:23 ` Jim Ramsay 0 siblings, 0 replies; 3+ messages in thread From: Jim Ramsay @ 2005-08-17 15:23 UTC (permalink / raw) To: Jeff Garzik; +Cc: Linux-ide On 8/16/05, Jeff Garzik <jgarzik@pobox.com> wrote: > Jim Ramsay wrote: > > I'm just looking into libata-scsi.c, and noticed that the comments for > > ata_scs_queuecmd note that it is supposed to obtain host_set->lock. > > It doesn't seem to do so. > > > > Should it? > > The SCSI layer acquires this lock for us. Ah yes, now I see - This lock is also pointed at by the host->host_lock -- Jim Ramsay "Me fail English? That's unpossible!" ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-17 15:23 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2005-08-16 22:21 ata_scsi_queuecmd locking question Jim Ramsay 2005-08-16 22:35 ` Jeff Garzik 2005-08-17 15:23 ` Jim Ramsay
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).