From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Michael Madore <Michael.Madore@aslab.com>,
linux-ide@vger.kernel.org, albertcc@tw.ibm.com
Subject: Re: [PATCH libata:upstream] sil: apply M15W quirk selectively
Date: Mon, 22 Aug 2005 17:45:12 -0400 [thread overview]
Message-ID: <430A4768.4000201@pobox.com> (raw)
In-Reply-To: <20050822213912.GA13920@htj.dyndns.org>
Tejun Heo wrote:
> On Mon, Aug 22, 2005 at 03:36:57PM -0400, Jeff Garzik wrote:
>>Tejun Heo wrote:
>>5) add SIL_FLAG_M15W to the list of host_flags in the new sil_3112_m15w
>>entry created in step #4.
> Can we use host_flags for that? It seems that it's for ATA_FLAG_*
> flags, and we currently don't explicitly reserve any bits from
> ATA_FLAG_*.
The drivers are free to use the upper bits of ap->flags for their own
purposes. ata_piix.c is an example of this, with PIIX_FLAG_xxx.
We can worry about bitspace collision when libata general flags and
driver-specific flags get so numerous its a problem.
Jeff
next prev parent reply other threads:[~2005-08-22 21:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1121894035.4885.15.camel@drevil.aslab.com>
2005-07-28 14:12 ` [PATCH linux-2.6.13-rc3] Mod15Write quirk against v2.6.13 Tejun Heo
2005-08-21 19:19 ` Jeff Garzik
2005-08-21 20:45 ` Tejun Heo
2005-08-21 21:10 ` Jeff Garzik
2005-08-21 21:44 ` Tejun Heo
2005-08-22 10:19 ` Bartlomiej Zolnierkiewicz
2005-08-22 11:46 ` [PATCH libata:upstream] sil: apply M15W quirk selectively Tejun Heo
2005-08-22 19:36 ` Jeff Garzik
2005-08-22 21:39 ` Tejun Heo
2005-08-22 21:45 ` Jeff Garzik [this message]
2005-08-22 22:27 ` [PATCH libata:upstream] sil: apply M15W quirk selectively (take 2) Tejun Heo
2005-08-23 5:06 ` Jeff Garzik
2005-08-21 19:34 ` [PATCH linux-2.6.13-rc3] Mod15Write quirk against v2.6.13 Jeff Garzik
2005-08-21 19:56 ` Tejun Heo
2005-08-21 20:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430A4768.4000201@pobox.com \
--to=jgarzik@pobox.com \
--cc=Michael.Madore@aslab.com \
--cc=albertcc@tw.ibm.com \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).