From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH libata:upstream] sil: apply M15W quirk selectively Date: Mon, 22 Aug 2005 17:45:12 -0400 Message-ID: <430A4768.4000201@pobox.com> References: <1121894035.4885.15.camel@drevil.aslab.com> <20050728141242.GA10010@htj.dyndns.org> <4308D3D0.50504@pobox.com> <4308E7F4.3000509@gmail.com> <4308EDB5.6060102@pobox.com> <4308F5CD.7060001@gmail.com> <58cb370e05082203194cf1f424@mail.gmail.com> <20050822114639.GA26607@htj.dyndns.org> <430A2959.300@pobox.com> <20050822213912.GA13920@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:6791 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751266AbVHVVpW (ORCPT ); Mon, 22 Aug 2005 17:45:22 -0400 In-Reply-To: <20050822213912.GA13920@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Bartlomiej Zolnierkiewicz , Michael Madore , linux-ide@vger.kernel.org, albertcc@tw.ibm.com Tejun Heo wrote: > On Mon, Aug 22, 2005 at 03:36:57PM -0400, Jeff Garzik wrote: >>Tejun Heo wrote: >>5) add SIL_FLAG_M15W to the list of host_flags in the new sil_3112_m15w >>entry created in step #4. > Can we use host_flags for that? It seems that it's for ATA_FLAG_* > flags, and we currently don't explicitly reserve any bits from > ATA_FLAG_*. The drivers are free to use the upper bits of ap->flags for their own purposes. ata_piix.c is an example of this, with PIIX_FLAG_xxx. We can worry about bitspace collision when libata general flags and driver-specific flags get so numerous its a problem. Jeff