From: George Anzinger <george@mvista.com>
To: Jim Ramsay <jim.ramsay@gmail.com>
Cc: Linux-ide <linux-ide@vger.kernel.org>,
Lukasz Kosewski <lkosewsk@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
Date: Tue, 23 Aug 2005 15:56:16 -0700 [thread overview]
Message-ID: <430BA990.9090807@mvista.com> (raw)
In-Reply-To: <4789af9e050823154364c8e9eb@mail.gmail.com>
Jim Ramsay wrote:
> On 8/23/05, Jim Ramsay <jim.ramsay@gmail.com> wrote:
>
>>Then I must have found an undocumented feature! I've applied this set
>>of patches to a 2.6.11 kernel (with few problems) and ran into a bunch
>>of "scheduling while atomic" errors when hotplugging a drive, culprit
>>being probably scsi_sysfs.c where scsi_remove_device locks a mutex, or
>>perhaps when it then calls class_device_unregister, which does a
>>'down_write'.
>
>
> After further debugging, it appears that the problem is the debounce
> timer in libata-core.c.
>
> Timers appear to operate in an atomic context, so timers should not be
> allowed to call scsi_remove_device, which eventually schedules.
>
> Any suggestions on the best way to fix this?
Workqueue, perhaps.
>
--
George Anzinger george@mvista.com
HRT (High-res-timers): http://sourceforge.net/projects/high-res-timers/
next prev parent reply other threads:[~2005-08-23 22:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 10:02 [PATCH 3/3] Add disk hotswap support to libata RESEND #2 Lukasz Kosewski
2005-08-23 19:41 ` Jim Ramsay
2005-08-23 22:43 ` Jim Ramsay
2005-08-23 22:56 ` George Anzinger [this message]
2005-08-24 1:20 ` Stefan Richter
2005-08-24 14:03 ` Lukasz Kosewski
2005-08-24 15:11 ` Jim Ramsay
2005-08-24 16:12 ` Jim Ramsay
[not found] ` <4789af9e0508291223435f174@mail.gmail.com>
2005-08-29 19:45 ` Jim Ramsay
2005-09-06 19:02 ` Jim Ramsay
2005-09-15 4:40 ` Lukasz Kosewski
2005-09-16 16:11 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430BA990.9090807@mvista.com \
--to=george@mvista.com \
--cc=jgarzik@pobox.com \
--cc=jim.ramsay@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).