From: Jeff Garzik <jgarzik@pobox.com>
To: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Another libata TODO item
Date: Wed, 24 Aug 2005 02:17:11 -0400 [thread overview]
Message-ID: <430C10E7.9060502@pobox.com> (raw)
Difficulty: beginner / intermediate
Modern network drivers have a per-NIC list of debugging messages that
can be enabled/disabled at runtime, implemented as a bitmask named
'msg_enable' in each driver. VERY useful for tracing specific events
during debugging. grep for 'msg_enable', 'netif_msg_', and 'NETIF_MSG_'.
To make libata debugging easier and more fine-grained, we should convert
DPRINTK/VPRINTK calls in libata to code that looks like
if (ata_msg_xxx(ap->msg_enable))
printk(...)
The task involves:
* reviewing net driver msg_enable usage
* reviewing original netif_msg documentation by Donald Becker, at
(scroll down)
http://www.scyld.com/pipermail/vortex/2001-November/001426.html
* designing a sliding scale of ever-more-verbose classes of messages,
for libata and libata drivers
* design a method by which userspace may change the per-port msg_enable
variable in libata
* implement the sliding scale as ATA_MSG_xxx / ata_msg_xxx()
* add msg_enable to struct ata_port
* implement method of setting ap->msg_enable via userspace
* convert messages in libata-core/libata-scsi
* convert messages in each driver
* add 'debug' module option to each driver, in a manner that duplicates
net driver module options
* test!
next reply other threads:[~2005-08-24 6:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 6:17 Jeff Garzik [this message]
2005-08-24 7:41 ` Another libata TODO item Christoph Hellwig
2005-08-24 7:51 ` Jeff Garzik
2005-08-24 16:15 ` Roland Dreier
2005-08-24 16:53 ` Jeff Garzik
2005-08-24 17:19 ` Roland Dreier
2005-08-24 17:24 ` Jeff Garzik
[not found] ` <200508242304.22998.petkov@uni-muenster.de>
2005-08-25 16:36 ` [RFC] libata debugging Borislav Petkov
2005-08-28 6:40 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430C10E7.9060502@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).