From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Another libata TODO item
Date: Wed, 24 Aug 2005 03:51:58 -0400 [thread overview]
Message-ID: <430C271E.7060006@pobox.com> (raw)
In-Reply-To: <20050824074116.GF24513@infradead.org>
Christoph Hellwig wrote:
> On Wed, Aug 24, 2005 at 02:17:11AM -0400, Jeff Garzik wrote:
>>To make libata debugging easier and more fine-grained, we should convert
>>DPRINTK/VPRINTK calls in libata to code that looks like
>>
>> if (ata_msg_xxx(ap->msg_enable))
>> printk(...)
>
>
> Would be nice if you could move that one up to the scsi layer and combine
> it with the existing scsi core loglevel handling.
Doubtful. libata's use of SCSI will become optional, so using SCSI
logging throughout libata core would be inappropriate. Block layer
would be more reasonable.
In any case, I also contine to be skeptical of in-kernel logging subsystems.
Jeff
next prev parent reply other threads:[~2005-08-24 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 6:17 Another libata TODO item Jeff Garzik
2005-08-24 7:41 ` Christoph Hellwig
2005-08-24 7:51 ` Jeff Garzik [this message]
2005-08-24 16:15 ` Roland Dreier
2005-08-24 16:53 ` Jeff Garzik
2005-08-24 17:19 ` Roland Dreier
2005-08-24 17:24 ` Jeff Garzik
[not found] ` <200508242304.22998.petkov@uni-muenster.de>
2005-08-25 16:36 ` [RFC] libata debugging Borislav Petkov
2005-08-28 6:40 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430C271E.7060006@pobox.com \
--to=jgarzik@pobox.com \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).