#undef ATA_ENABLE_PATA

#undef ATA_ENABLE_PATA

[Horms]

Hi Jeff, Hi All,

In the cause of debuging a problem with a DVD burner[1]
Brett Smith brought to my attention that there are several
variables in ./include/linux/libata.h, that when changed
from #undef to #define, enable features in the ATA subsystem.

Is there any interest in a patch to make any/all of these configurable
through Kconfig, or are they too hackish/dangerous/whatever to consider.
I'm more than happy to make a patch if there is interest, please let me
know wither way.

Specifically, I am refering to:

/*
 * compile-time options
 */
#undef ATA_DEBUG                /* debugging output */
#undef ATA_VERBOSE_DEBUG        /* yet more debugging output */
#undef ATA_IRQ_TRAP             /* define to ack screaming irqs */
#undef ATA_NDEBUG               /* define to disable quick runtime checks */
#undef ATA_ENABLE_ATAPI         /* define to enable ATAPI support */
#undef ATA_ENABLE_PATA          /* define to enable PATA support in some
                                 * low-level drivers */
#undef ATAPI_ENABLE_DMADIR      /* enables ATAPI DMADIR bridge support */


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=319659

-- 
Horms

Re: #undef ATA_ENABLE_PATA

[Jeff Garzik]

Horms wrote:
> Hi Jeff, Hi All,
> 
> In the cause of debuging a problem with a DVD burner[1]
> Brett Smith brought to my attention that there are several
> variables in ./include/linux/libata.h, that when changed
> from #undef to #define, enable features in the ATA subsystem.
> 
> Is there any interest in a patch to make any/all of these configurable
> through Kconfig, or are they too hackish/dangerous/whatever to consider.
> I'm more than happy to make a patch if there is interest, please let me
> know wither way.
> 
> Specifically, I am refering to:
> 
> /*
>  * compile-time options
>  */
> #undef ATA_DEBUG                /* debugging output */
> #undef ATA_VERBOSE_DEBUG        /* yet more debugging output */

These should go away, once ATA_MSG_xxx is implemented (a la NETIF_MSG_xxx).


> #undef ATA_IRQ_TRAP             /* define to ack screaming irqs */
> #undef ATA_NDEBUG               /* define to disable quick runtime checks */
> #undef ATA_ENABLE_ATAPI         /* define to enable ATAPI support */
> #undef ATA_ENABLE_PATA          /* define to enable PATA support in some
>                                  * low-level drivers */
> #undef ATAPI_ENABLE_DMADIR      /* enables ATAPI DMADIR bridge support */

These are all things that are either incomplete, or should not be 
configured by non-developers.

When something is safe to turn on in the upstream kernel, it gets turned 
on :)  This is why ATAPI defaults to off, even though some silly distros 
turn it on.

	Jeff

Re: #undef ATA_ENABLE_PATA

[Horms]

On Fri, Aug 26, 2005 at 12:55:23AM -0400, Jeff Garzik wrote:
> Horms wrote:
> >Hi Jeff, Hi All,
> >
> >In the cause of debuging a problem with a DVD burner[1]
> >Brett Smith brought to my attention that there are several
> >variables in ./include/linux/libata.h, that when changed
> >from #undef to #define, enable features in the ATA subsystem.
> >
> >Is there any interest in a patch to make any/all of these configurable
> >through Kconfig, or are they too hackish/dangerous/whatever to consider.
> >I'm more than happy to make a patch if there is interest, please let me
> >know wither way.
> >
> >Specifically, I am refering to:
> >
> >/*
> > * compile-time options
> > */
> >#undef ATA_DEBUG                /* debugging output */
> >#undef ATA_VERBOSE_DEBUG        /* yet more debugging output */
> 
> These should go away, once ATA_MSG_xxx is implemented (a la NETIF_MSG_xxx).
> 
> 
> >#undef ATA_IRQ_TRAP             /* define to ack screaming irqs */
> >#undef ATA_NDEBUG               /* define to disable quick runtime checks 
> >*/
> >#undef ATA_ENABLE_ATAPI         /* define to enable ATAPI support */
> >#undef ATA_ENABLE_PATA          /* define to enable PATA support in some
> >                                 * low-level drivers */
> >#undef ATAPI_ENABLE_DMADIR      /* enables ATAPI DMADIR bridge support */
> 
> These are all things that are either incomplete, or should not be 
> configured by non-developers.
> 
> When something is safe to turn on in the upstream kernel, it gets turned 
> on :)  This is why ATAPI defaults to off, even though some silly distros 
> turn it on.

Thanks Jeff, I suspected something along those lines.

-- 
Horms

Re: #undef ATA_ENABLE_PATA

[Erik Slagter]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

On Fri, 2005-08-26 at 13:36 +0900, Horms wrote:

> #undef ATA_ENABLE_ATAPI         /* define to enable ATAPI support */
> #undef ATA_ENABLE_PATA          /* define to enable PATA support in some

These two would very interesting to me to be included in Kconfig.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2115 bytes --]

Re: #undef ATA_ENABLE_PATA

[Jeff Garzik]

Erik Slagter wrote:
> On Fri, 2005-08-26 at 13:36 +0900, Horms wrote:
> 
> 
>>#undef ATA_ENABLE_ATAPI         /* define to enable ATAPI support */
>>#undef ATA_ENABLE_PATA          /* define to enable PATA support in some
> 
> 
> These two would very interesting to me to be included in Kconfig.

Neither of these are ready for prime time, with known problems.  Move 
them to Kconfig, and I have to deal with the bug reports.  No thanks...

	Jeff