From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: add ATAPI module option
Date: Tue, 30 Aug 2005 21:52:36 -0400 [thread overview]
Message-ID: <43150D64.1060208@pobox.com> (raw)
In-Reply-To: <4314F1C8.8040706@rtr.ca>
Mark Lord wrote:
> Jeff Garzik wrote:
>
>>
>> -#ifndef ATA_ENABLE_ATAPI
>> - if (unlikely(dev->class == ATA_DEV_ATAPI))
>> - return NULL;
>> -#endif
>> + if (atapi_enabled) {
>> + if (unlikely(dev->class == ATA_DEV_ATAPI))
>> + return NULL;
>> + }
>
> ..
>
> Is that if-stmt the right way around?
> At first glance, I'd expect it to read:
>
> if (!atapi_enabled) {
> ...
>
> Cheers!
Indeed, thanks, fixed.
Jeff
next prev parent reply other threads:[~2005-08-31 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 21:52 [PATCH] libata: add ATAPI module option Jeff Garzik
2005-08-30 23:54 ` Mark Lord
2005-08-31 1:52 ` Jeff Garzik [this message]
2005-10-22 3:25 ` Mark Lord
2005-10-22 3:34 ` Jeff Garzik
2005-10-22 4:00 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43150D64.1060208@pobox.com \
--to=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).