Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

[Jeff Garzik <jgarzik@pobox.com>]

Christoph Hellwig wrote:
> On Thu, Sep 01, 2005 at 03:48:51PM -0400, Jeff Garzik wrote:
> 
>>Christoph Hellwig wrote:
>>
>>>>+#include <linux/kernel.h>
>>>>+#include <linux/module.h>
>>>>+#include <linux/pci.h>
>>>>+#include <linux/init.h>
>>>>+#include <linux/blkdev.h>
>>>>+#include <linux/delay.h>
>>>>+#include <linux/interrupt.h>
>>>>+#include <linux/sched.h>
>>>>+#include <linux/dma-mapping.h>
>>>>+#include "scsi.h"
>>>
>>>
>>>pleaese don't include "scsi.h" in new drivers.  It will go away soon.
>>>Use the <scsi/*.h> headers and get rid of usage of obsolete constucts
>>>in your driver.
>>
>>
>>It stays until the rest of the libata drivers lose the include.
>>
>>After ATAPI support is done, I can stop 2.4.x support, and this and 
>>several other compat-isms will go away.
> 
> 
> NACK.  Jeff, I accept that you don't want to convert old drivers yet,
> but this is not acceptable for new drivers.  We don't allow it for any
> new scsi LLDDs, and that includes libata drivers.

Sorry, you don't get to NAK that change, since it affects 2.4.x 
maintenance of this new driver.

As I said, the include does away simultaneously for all libata drivers.

	Jeff