From: Jeff Garzik <jgarzik@pobox.com>
To: Brett M Russ <russb@emc.com>
Cc: Greg KH <greg@kroah.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg KH <gregkh@suse.de>,
linux-pci@atrey.karlin.mff.cuni.cz, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.13] PCI/libata INTx bug fix
Date: Fri, 09 Sep 2005 11:37:09 -0400 [thread overview]
Message-ID: <4321AC25.8090508@pobox.com> (raw)
In-Reply-To: <20050909130440.4E31E271E6@lns1058.lss.emc.com>
Brett M Russ wrote:
> Previous INTx cleanup patch had a bug that was not caught. I found
> this last night during testing and can confirm that it is now 100%
> working.
>
> Signed-off-by: Brett Russ <russb@emc.com>
>
>
> Index: linux-2.6.13/drivers/pci/pci.c
> ===================================================================
> --- linux-2.6.13.orig/drivers/pci/pci.c
> +++ linux-2.6.13/drivers/pci/pci.c
> @@ -764,7 +764,7 @@ pci_intx(struct pci_dev *pdev, int enabl
> }
>
> if (new != pci_command) {
> - pci_write_config_word(pdev, PCI_COMMAND, pci_command);
> + pci_write_config_word(pdev, PCI_COMMAND, new);
If GregKH doesn't pick this up, I'll send it to Andrew/Linus ASAP.
libata is the only user currently, and we definitely need this fix.
Jeff
next prev parent reply other threads:[~2005-09-09 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-03 20:47 [PATCH 2.6.12.3] PCI/libata INTx cleanup Brett Russ
2005-08-11 19:01 ` Jeff Garzik
2005-08-12 17:10 ` Brett Russ
[not found] ` <20050812171043.CF61020E8B@lns1058.lss.emc.com>
2005-08-12 18:22 ` Greg KH
2005-08-12 18:49 ` Brett Russ
2005-08-12 21:30 ` Jeff Garzik
2005-08-12 22:43 ` [PATCH 2.6.13-rc6] " Brett Russ
2005-08-13 0:29 ` Jeff Garzik
2005-08-15 16:31 ` Greg KH
2005-08-15 18:57 ` Greg KH
2005-08-15 19:08 ` Brett Russ
2005-08-15 20:06 ` Greg KH
2005-08-15 20:17 ` Brett Russ
2005-08-15 19:17 ` Jeff Garzik
2005-08-15 19:23 ` Brett M Russ
[not found] ` <1126218402469@kroah.com>
2005-09-09 13:04 ` [PATCH 2.6.13] PCI/libata INTx bug fix Brett M Russ
2005-09-09 15:37 ` Jeff Garzik [this message]
2005-09-09 17:02 ` [PATCH] PCI: " Greg KH
2005-09-09 17:04 ` Jeff Garzik
2005-08-12 21:44 ` [PATCH 2.6.12.3] PCI/libata INTx cleanup Brian Gerst
2005-08-12 21:49 ` Greg KH
2005-08-12 21:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4321AC25.8090508@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=russb@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).