From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h) Date: Sat, 10 Sep 2005 20:47:52 -0400 Message-ID: <43237EB8.90809@pobox.com> References: <200509102032.j8AKWxMC006246@localhost.localdomain> <4323482E.2090409@pobox.com> <20050910211932.GA13679@kroah.com> <432352A8.3010605@pobox.com> <20050910223333.GF4770@parisc-linux.org> <43236DAE.8000802@pobox.com> <20050911003409.GB25282@colo.lackof.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:64662 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932737AbVIKAsG (ORCPT ); Sat, 10 Sep 2005 20:48:06 -0400 In-Reply-To: <20050911003409.GB25282@colo.lackof.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Grant Grundler Cc: Matthew Wilcox , Greg KH , Jiri Slaby , Greg KH , Linux Kernel Mailing List , linux-pci@atrey.karlin.mff.cuni.cz, linux-ide@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl Grant Grundler wrote: > On Sat, Sep 10, 2005 at 07:35:10PM -0400, Jeff Garzik wrote: > >>>Why not change it to query whether any IDE device is present, perhaps >>>using pci_get_class()? >> >>Because that's not what the code is attempting to discover. > > > If ide_scan_pcibus() finds any pci device, it calls ide_scan_pcidev(). > ide_scan_pcidev() only seems to handle PCI devices. > Are you saying there are PCI IDE devices out there that > don't advertise PCI_CLASS_STORAGE_IDE? The code is not searching for PCI devices. The code is searching for... precisely what it is searching for: presence of PCI in the system. Jeff