linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: lkosewsk@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2.6.14-rc1 1/3] Add disk hotswap support to libata RESEND #3
Date: Thu, 15 Sep 2005 23:08:24 -0400	[thread overview]
Message-ID: <432A3728.6040501@pobox.com> (raw)
In-Reply-To: <355e5e5e05091422061a3a9f28@mail.gmail.com>

Lukasz Kosewski wrote:
> Patch 1/3 for libata hotswapping.  Properly masks out interrupts for
> Promise SATAII150 Tx2Plus/Tx4 controllers.  More comments in patch
> header.
> 
> Luke Kosewski
> 
> 
> ------------------------------------------------------------------------
> 
> 15.09.05    Luke Kosewski   <lkosewsk@nit.ca>
> 
> 	* A patch to the sata_promise driver in libata for it to correctly mask
> 	  out hotplug interrupts on SATAII150 Tx4/Tx2 Plus controllers.
> 	* This is resend #3.  It no longer applies to a -mm tree, but to
> 	  2.6.14-rc1.  Therefore, the entry for board_2057x no longer has
> 	  ATA_FLAG_SATA commented out.

You need to add a ->host_stop() hook that frees pdc_host_priv, otherwise 
you have a memory leak on module remove/controller unplug.

Once fixed, this patch could go in immediately, it looks like.

	Jeff




      reply	other threads:[~2005-09-16  3:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-15  5:06 [PATCH 2.6.14-rc1 1/3] Add disk hotswap support to libata RESEND #3 Lukasz Kosewski
2005-09-16  3:08 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=432A3728.6040501@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkosewsk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).