* Re: libata sata_sil broken on 2.6.13.1 [not found] ` <61375.200.141.106.169.1126842173.squirrel@correio.lps.ele.puc-rio.br> @ 2005-09-16 6:41 ` Jeff Garzik 2005-09-16 22:10 ` Matheus Izvekov 0 siblings, 1 reply; 3+ messages in thread From: Jeff Garzik @ 2005-09-16 6:41 UTC (permalink / raw) To: izvekov; +Cc: Alan Cox, linux-kernel, linux-ide@vger.kernel.org izvekov@lps.ele.puc-rio.br wrote: >From what i understand up to now, my problem wasnt that the controller > triggered an interrupt with NIEN set, but that the handler was returning > it as not handled. Essentially that is what happened. Albert's patch simply fixed it another way. ATA is a bit annoying in that, we try to "know" when an interrupt is expected. There is no 100% solution that simply allows us to check for pending interrupts, without side effects. Thus the explosion when unexpected interrupts are received. Jeff ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libata sata_sil broken on 2.6.13.1 2005-09-16 6:41 ` libata sata_sil broken on 2.6.13.1 Jeff Garzik @ 2005-09-16 22:10 ` Matheus Izvekov 2005-09-22 2:46 ` Jeff Garzik 0 siblings, 1 reply; 3+ messages in thread From: Matheus Izvekov @ 2005-09-16 22:10 UTC (permalink / raw) To: Jeff Garzik; +Cc: izvekov, Alan Cox, linux-kernel, linux-ide@vger.kernel.org > Essentially that is what happened. Albert's patch simply fixed it > another way. > > ATA is a bit annoying in that, we try to "know" when an interrupt is > expected. There is no 100% solution that simply allows us to check for > pending interrupts, without side effects. > > Thus the explosion when unexpected interrupts are received. > What do you think would be proper fix, this patch from Albert, or maybe just trapping the interrupts (plus not have the IRQ shared with other devices?). Also, what keeps Albert's patch from making into mainline, it just needs more testing or are there any known problems? > Jeff Thanks for your support. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libata sata_sil broken on 2.6.13.1 2005-09-16 22:10 ` Matheus Izvekov @ 2005-09-22 2:46 ` Jeff Garzik 0 siblings, 0 replies; 3+ messages in thread From: Jeff Garzik @ 2005-09-22 2:46 UTC (permalink / raw) To: Matheus Izvekov; +Cc: Alan Cox, linux-kernel, linux-ide@vger.kernel.org Matheus Izvekov wrote: >>Essentially that is what happened. Albert's patch simply fixed it >>another way. >> >>ATA is a bit annoying in that, we try to "know" when an interrupt is >>expected. There is no 100% solution that simply allows us to check for >>pending interrupts, without side effects. >> >>Thus the explosion when unexpected interrupts are received. >> > > > What do you think would be proper fix, this patch from Albert, or maybe Albert's patch should be the proper fix. > just trapping the interrupts (plus not have the IRQ shared with other > devices?). Also, what keeps Albert's patch from making into mainline, it > just needs more testing or are there any known problems? Albert's patch needs to be fleshed out a bit more. No fundamental problems, just the stuff I mentioned, plus a final review. It also needs to be tested on EVERY controller that we support, since this is a fundamental change in how ALL sata devices are probed. Jeff ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-09-22 2:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <61637.200.141.106.169.1126660632.squirrel@correio.lps.ele.puc-rio.br>
[not found] ` <60519.200.141.106.169.1126727337.squirrel@correio.lps.ele.puc-rio.br>
[not found] ` <43290893.7070207@pobox.com>
[not found] ` <1126790860.19133.75.camel@localhost.localdomain>
[not found] ` <61929.200.141.106.169.1126815191.squirrel@correio.lps.ele.puc-rio.br>
[not found] ` <1126823405.7034.14.camel@localhost.localdomain>
[not found] ` <61375.200.141.106.169.1126842173.squirrel@correio.lps.ele.puc-rio.br>
2005-09-16 6:41 ` libata sata_sil broken on 2.6.13.1 Jeff Garzik
2005-09-16 22:10 ` Matheus Izvekov
2005-09-22 2:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).