From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: libata sata_sil broken on 2.6.13.1 Date: Wed, 21 Sep 2005 22:46:49 -0400 Message-ID: <43321B19.7000302@pobox.com> References: <61637.200.141.106.169.1126660632.squirrel@correio.lps.ele.puc-rio.br><60519.200.141.106.169.1126727337.squirrel@correio.lps.ele.puc-rio.br><43290893.7070207@pobox.com><1126790860.19133.75.camel@localhost.localdomain><61929.200.141.106.169.1126815191.squirrel@correio.lps.ele.puc-rio.br> <1126823405.7034.14.camel@localhost.localdomain> <61375.200.141.106.169.1126842173.squirrel@correio.lps.ele.puc-rio.br> <432A6923.2070000@pobox.com> <60542.200.141.101.221.1126908642.squirrel@correio.lps.ele.puc-rio.br> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:49831 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S965220AbVIVCqz (ORCPT ); Wed, 21 Sep 2005 22:46:55 -0400 In-Reply-To: <60542.200.141.101.221.1126908642.squirrel@correio.lps.ele.puc-rio.br> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Matheus Izvekov Cc: Alan Cox , linux-kernel@vger.kernel.org, "linux-ide@vger.kernel.org" Matheus Izvekov wrote: >>Essentially that is what happened. Albert's patch simply fixed it >>another way. >> >>ATA is a bit annoying in that, we try to "know" when an interrupt is >>expected. There is no 100% solution that simply allows us to check for >>pending interrupts, without side effects. >> >>Thus the explosion when unexpected interrupts are received. >> > > > What do you think would be proper fix, this patch from Albert, or maybe Albert's patch should be the proper fix. > just trapping the interrupts (plus not have the IRQ shared with other > devices?). Also, what keeps Albert's patch from making into mainline, it > just needs more testing or are there any known problems? Albert's patch needs to be fleshed out a bit more. No fundamental problems, just the stuff I mentioned, plus a final review. It also needs to be tested on EVERY controller that we support, since this is a fundamental change in how ALL sata devices are probed. Jeff