[PATCH] libata: scsi error handling, lk 2.6.14-rc1

[PATCH] libata: scsi error handling, lk 2.6.14-rc1

[Douglas Gilbert]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

Jeff,
This is a retransmission (and resync against lk 2.6.14-rc1)
of a patch that I sent on 2005/8/28 . I haven't seen a reply.

If it has be applied, then my following patch
("[PATCH] libata: ATA Information VPD page, lk 2.6.14-rc1")
should apply.

This patch adds more general error processing, typically for
problems (or an early finish) detected while a
SCSI command is being processed prior to an ATA
command being executed.

Changelog:
  - add extern ata_scsi_set_sense() to build SCSI
    sense data and corresponding status
  - this allows removal of extern ata_scsi_badcmd()
    and static inline ata_bad_scsiop() and ata_bad_cdb()
  - change "xlat" functions in libata-scsi so they
    are responsible for SCSI status and sense data
    when they return 1. This allows GOOD status or a
    specialized error to be set.
  - set DRIVER_SENSE when SAM_STAT_CHECK_CONDITION
    is flagged in scsi_cmnd::result
  - yield an error for mode sense requests for saved
    values [sat-r05]
  - change recent rw_zero_length patch to do nothing
    (yield GOOD status) when transfer_length==0 for
    10 and 16 byte READ and WRITE commands (SBC-2).

Signed-off-by: Douglas Gilbert <dougg@torque.net>

Doug Gilbert

[-- Attachment #2: libata2614rc1_err.diff --]
[-- Type: text/x-patch, Size: 12548 bytes --]

--- linux/drivers/scsi/libata.h	2005-09-15 14:58:17.000000000 +1000
+++ linux/drivers/scsi/libata.h2614rc1err	2005-09-16 22:05:42.000000000 +1000
@@ -76,18 +76,10 @@
 extern void ata_scsi_badcmd(struct scsi_cmnd *cmd,
 			    void (*done)(struct scsi_cmnd *),
 			    u8 asc, u8 ascq);
+extern void ata_scsi_set_sense(struct scsi_cmnd *cmd,
+			       u8 sk, u8 asc, u8 ascq);
 extern void ata_scsi_rbuf_fill(struct ata_scsi_args *args,
                         unsigned int (*actor) (struct ata_scsi_args *args,
                                            u8 *rbuf, unsigned int buflen));
 
-static inline void ata_bad_scsiop(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *))
-{
-	ata_scsi_badcmd(cmd, done, 0x20, 0x00);
-}
-
-static inline void ata_bad_cdb(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *))
-{
-	ata_scsi_badcmd(cmd, done, 0x24, 0x00);
-}
-
 #endif /* __LIBATA_H__ */
--- linux/drivers/scsi/libata-scsi.c	2005-09-15 14:58:17.000000000 +1000
+++ linux/drivers/scsi/libata-scsi.c2614rc1err	2005-09-16 22:00:05.000000000 +1000
@@ -48,6 +48,14 @@
 static struct ata_device *
 ata_scsi_find_dev(struct ata_port *ap, struct scsi_device *scsidev);
 
+static void ata_scsi_invalid_field(struct scsi_cmnd *cmd,
+				   void (*done)(struct scsi_cmnd *))
+{
+	ata_scsi_set_sense(cmd, ILLEGAL_REQUEST, 0x24, 0x0);
+	/* "Invalid field in cbd" */
+	done(cmd);
+}
+
 
 /**
  *	ata_std_bios_param - generic bios head/sector/cylinder calculator used by sd.
@@ -182,7 +190,6 @@
 {
 	struct scsi_cmnd *cmd = qc->scsicmd;
 	u8 err = 0;
-	unsigned char *sb = cmd->sense_buffer;
 	/* Based on the 3ware driver translation table */
 	static unsigned char sense_table[][4] = {
 		/* BBD|ECC|ID|MAR */
@@ -225,8 +232,6 @@
 	};
 	int i = 0;
 
-	cmd->result = SAM_STAT_CHECK_CONDITION;
-
 	/*
 	 *	Is this an error we can process/parse
 	 */
@@ -281,11 +286,9 @@
 		/* Look for best matches first */
 		if((sense_table[i][0] & err) == sense_table[i][0])
 		{
-			sb[0] = 0x70;
-			sb[2] = sense_table[i][1];
-			sb[7] = 0x0a;
-			sb[12] = sense_table[i][2];
-			sb[13] = sense_table[i][3];
+			ata_scsi_set_sense(cmd, sense_table[i][1] /* sk */,
+					   sense_table[i][2] /* asc */,
+					   sense_table[i][3] /* ascq */ );
 			return;
 		}
 		i++;
@@ -300,11 +303,9 @@
 	{
 		if(stat_table[i][0] & drv_stat)
 		{
-			sb[0] = 0x70;
-			sb[2] = stat_table[i][1];
-			sb[7] = 0x0a;
-			sb[12] = stat_table[i][2];
-			sb[13] = stat_table[i][3];
+			ata_scsi_set_sense(cmd, sense_table[i][1] /* sk */,
+					   sense_table[i][2] /* asc */,
+					   sense_table[i][3] /* ascq */ );
 			return;
 		}
 		i++;
@@ -313,15 +314,12 @@
 	printk(KERN_ERR "ata%u: called with no error (%02X)!\n", qc->ap->id, drv_stat);
 	/* additional-sense-code[-qualifier] */
 
-	sb[0] = 0x70;
-	sb[2] = MEDIUM_ERROR;
-	sb[7] = 0x0A;
 	if (cmd->sc_data_direction == DMA_FROM_DEVICE) {
-		sb[12] = 0x11; /* "unrecovered read error" */
-		sb[13] = 0x04;
+		ata_scsi_set_sense(cmd, MEDIUM_ERROR, 0x11, 0x4);
+		/* "unrecovered read error" */
 	} else {
-		sb[12] = 0x0C; /* "write error -             */
-		sb[13] = 0x02; /*  auto-reallocation failed" */
+		ata_scsi_set_sense(cmd, MEDIUM_ERROR, 0xc, 0x2);
+		/* "write error - auto-reallocation failed" */
 	}
 }
 
@@ -430,9 +428,9 @@
 		;	/* ignore IMMED bit, violates sat-r05 */
 	}
 	if (scsicmd[4] & 0x2)
-		return 1;	/* LOEJ bit set not supported */
+		goto invalid_fld;	/* LOEJ bit set not supported */
 	if (((scsicmd[4] >> 4) & 0xf) != 0)
-		return 1;	/* power conditions not supported */
+		goto invalid_fld;	/* power conditions not supported */
 	if (scsicmd[4] & 0x1) {
 		tf->nsect = 1;	/* 1 sector, lba=0 */
 		tf->lbah = 0x0;
@@ -453,6 +451,11 @@
 	 */
 
 	return 0;
+
+invalid_fld:
+	ata_scsi_set_sense(qc->scsicmd, ILLEGAL_REQUEST, 0x24, 0x0);
+        /* "Invalid field in cbd" */
+	return 1;
 }
 
 
@@ -540,20 +543,20 @@
 	}
 
 	else
-		return 1;
+		goto invalid_fld;
 
 	if (!n_sect)
-		return 1;
+		goto invalid_fld;
 	if (sect >= dev_sectors)
-		return 1;
+		goto invalid_fld;
 	if ((sect + n_sect) > dev_sectors)
-		return 1;
+		goto invalid_fld;
 	if (lba48) {
 		if (n_sect > (64 * 1024))
-			return 1;
+			goto invalid_fld;
 	} else {
 		if (n_sect > 256)
-			return 1;
+			goto invalid_fld;
 	}
 
 	if (lba48) {
@@ -577,6 +580,11 @@
 	tf->lbal = sect & 0xff;
 
 	return 0;
+
+invalid_fld:
+	ata_scsi_set_sense(qc->scsicmd, ILLEGAL_REQUEST, 0x24, 0x0);
+        /* "Invalid field in cbd" */
+	return 1;
 }
 
 /**
@@ -627,7 +635,7 @@
 			/* if we don't support LBA48 addressing, the request
 			 * -may- be too large. */
 			if ((scsicmd[2] & 0xf0) || scsicmd[7])
-				return 1;
+				goto out_of_range;
 
 			/* stores LBA27:24 in lower 4 bits of device reg */
 			tf->device |= scsicmd[2];
@@ -641,8 +649,8 @@
 		tf->lbah = scsicmd[3];
 
 		VPRINTK("ten-byte command\n");
-		if (qc->nsect == 0) /* we don't support length==0 cmds */
-			return 1;
+		if (qc->nsect == 0) /* skip length==0 cmds */
+			goto nothing_todo;
 		return 0;
 	}
 
@@ -664,8 +672,10 @@
 
 	if (scsicmd[0] == READ_16 || scsicmd[0] == WRITE_16) {
 		/* rule out impossible LBAs and sector counts */
-		if (scsicmd[2] || scsicmd[3] || scsicmd[10] || scsicmd[11])
-			return 1;
+		if (scsicmd[2] || scsicmd[3])
+			goto out_of_range;
+		if (scsicmd[10] || scsicmd[11])
+			goto invalid_fld;
 
 		if (lba48) {
 			tf->hob_nsect = scsicmd[12];
@@ -677,9 +687,10 @@
 					scsicmd[13];
 		} else {
 			/* once again, filter out impossible non-zero values */
-			if (scsicmd[4] || scsicmd[5] || scsicmd[12] ||
-			    (scsicmd[6] & 0xf0))
-				return 1;
+			if (scsicmd[4] || scsicmd[5] || (scsicmd[6] & 0xf0))
+				goto out_of_range;
+			if (scsicmd[12])
+				goto invalid_fld;
 
 			/* stores LBA27:24 in lower 4 bits of device reg */
 			tf->device |= scsicmd[6];
@@ -693,13 +704,25 @@
 		tf->lbah = scsicmd[7];
 
 		VPRINTK("sixteen-byte command\n");
-		if (qc->nsect == 0) /* we don't support length==0 cmds */
-			return 1;
+		if (qc->nsect == 0) /* skip length==0 cmds */
+			goto nothing_todo;
 		return 0;
 	}
 
+nothing_todo:
+	qc->scsicmd->result = SAM_STAT_GOOD;
 	DPRINTK("no-byte command\n");
 	return 1;
+
+invalid_fld:
+	ata_scsi_set_sense(qc->scsicmd, ILLEGAL_REQUEST, 0x24, 0x0);
+        /* "Invalid field in cbd" */
+	return 1;
+
+out_of_range:
+	ata_scsi_set_sense(qc->scsicmd, ILLEGAL_REQUEST, 0x21, 0x0);
+        /* "Logical Block Address out of range" */
+	return 1;
 }
 
 static int ata_scsi_qc_complete(struct ata_queued_cmd *qc, u8 drv_stat)
@@ -731,6 +754,12 @@
  *	This function sets up an ata_queued_cmd structure for the
  *	SCSI command, and sends that ata_queued_cmd to the hardware.
  *
+ *	xlat_func argument (actor) returns 0 if ready to execute ATA
+ *	command, else 1 to finish translation. If 1 is returned then
+ *	cmd->result (and possibly cmd->sense_buffer) are assumed to
+ *	be set reflecting an error condition or clean (early)
+ *	termination.
+ *
  *	LOCKING:
  *	spin_lock_irqsave(host_set lock)
  */
@@ -747,7 +776,7 @@
 
 	qc = ata_scsi_qc_new(ap, dev, cmd, done);
 	if (!qc)
-		return;
+		goto err_mem;
 
 	/* data is present; dma-map it */
 	if (cmd->sc_data_direction == DMA_FROM_DEVICE ||
@@ -755,7 +784,7 @@
 		if (unlikely(cmd->request_bufflen < 1)) {
 			printk(KERN_WARNING "ata%u(%u): WARNING: zero len r/w req\n",
 			       ap->id, dev->devno);
-			goto err_out;
+			goto err_did;
 		}
 
 		if (cmd->use_sg)
@@ -770,19 +799,28 @@
 	qc->complete_fn = ata_scsi_qc_complete;
 
 	if (xlat_func(qc, scsicmd))
-		goto err_out;
+		goto early_finish;
 
 	/* select device, send command to hardware */
 	if (ata_qc_issue(qc))
-		goto err_out;
+		goto err_did;
 
 	VPRINTK("EXIT\n");
 	return;
 
-err_out:
+early_finish:
 	ata_qc_free(qc);
-	ata_bad_cdb(cmd, done);
-	DPRINTK("EXIT - badcmd\n");
+	done(cmd);
+	DPRINTK("EXIT - early finish (good or error)\n");
+	return;
+
+err_did:
+	ata_qc_free(qc);
+err_mem:
+	cmd->result = (DID_ERROR << 16);
+	done(cmd);
+	DPRINTK("EXIT - internal\n");
+	return;
 }
 
 /**
@@ -849,7 +887,8 @@
  *	Mapping the response buffer, calling the command's handler,
  *	and handling the handler's return value.  This return value
  *	indicates whether the handler wishes the SCSI command to be
- *	completed successfully, or not.
+ *	completed successfully (0), or not (in which case cmd->result
+ *	and sense buffer are assumed to be set).
  *
  *	LOCKING:
  *	spin_lock_irqsave(host_set lock)
@@ -868,12 +907,9 @@
 	rc = actor(args, rbuf, buflen);
 	ata_scsi_rbuf_put(cmd, rbuf);
 
-	if (rc)
-		ata_bad_cdb(cmd, args->done);
-	else {
+	if (rc == 0)
 		cmd->result = SAM_STAT_GOOD;
-		args->done(cmd);
-	}
+	args->done(cmd);
 }
 
 /**
@@ -1179,8 +1215,16 @@
 	 * in the same manner)
 	 */
 	page_control = scsicmd[2] >> 6;
-	if ((page_control != 0) && (page_control != 3))
-		return 1;
+	switch (page_control) {
+	case 0:	/* current */
+		break;	/* supported */
+	case 3:	/* saved */
+		goto saving_not_supp;
+	case 1:	/* changeable */
+	case 2:	/* defaults */
+	default:
+		goto invalid_fld;
+	}
 
 	if (six_byte)
 		output_len = 4;
@@ -1211,7 +1255,7 @@
 		break;
 
 	default:		/* invalid page code */
-		return 1;
+		goto invalid_fld;
 	}
 
 	if (six_byte) {
@@ -1224,6 +1268,16 @@
 	}
 
 	return 0;
+
+invalid_fld:
+	ata_scsi_set_sense(args->cmd, ILLEGAL_REQUEST, 0x24, 0x0);
+        /* "Invalid field in cbd" */
+	return 1;
+
+saving_not_supp:
+	ata_scsi_set_sense(args->cmd, ILLEGAL_REQUEST, 0x39, 0x0);
+        /* "Saving parameters not supported" */
+	return 1;
 }
 
 /**
@@ -1313,6 +1367,34 @@
 }
 
 /**
+ *	ata_scsi_set_sense - Set SCSI sense data and status
+ *	@cmd: SCSI request to be handled
+ *	@sk: SCSI-defined sense key
+ *	@asc: SCSI-defined additional sense code
+ *	@ascq: SCSI-defined additional sense code qualifier
+ *
+ *	Helper function that builds a valid fixed format, current
+ *	response code and the given sense key (sk), additional sense
+ *	code (asc) and additional sense code qualifier (ascq) with
+ *	a SCSI command status of %SAM_STAT_CHECK_CONDITION and
+ *	DRIVER_SENSE set in the upper bits of scsi_cmnd::result .
+ *
+ *	LOCKING:
+ *	Not required
+ */
+
+void ata_scsi_set_sense(struct scsi_cmnd *cmd, u8 sk, u8 asc, u8 ascq)
+{
+	cmd->result = (DRIVER_SENSE << 24) | SAM_STAT_CHECK_CONDITION;
+
+	cmd->sense_buffer[0] = 0x70;	/* fixed format, current */
+	cmd->sense_buffer[2] = sk;
+	cmd->sense_buffer[7] = 18 - 8;	/* additional sense length */
+	cmd->sense_buffer[12] = asc;
+	cmd->sense_buffer[13] = ascq;
+}
+
+/**
  *	ata_scsi_badcmd - End a SCSI request with an error
  *	@cmd: SCSI request to be handled
  *	@done: SCSI command completion function
@@ -1330,13 +1412,7 @@
 void ata_scsi_badcmd(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *), u8 asc, u8 ascq)
 {
 	DPRINTK("ENTER\n");
-	cmd->result = SAM_STAT_CHECK_CONDITION;
-
-	cmd->sense_buffer[0] = 0x70;
-	cmd->sense_buffer[2] = ILLEGAL_REQUEST;
-	cmd->sense_buffer[7] = 14 - 8;	/* addnl. sense len. FIXME: correct? */
-	cmd->sense_buffer[12] = asc;
-	cmd->sense_buffer[13] = ascq;
+	ata_scsi_set_sense(cmd, ILLEGAL_REQUEST, asc, ascq);
 
 	done(cmd);
 }
@@ -1348,7 +1424,7 @@
 	if (unlikely(drv_stat & (ATA_ERR | ATA_BUSY | ATA_DRQ))) {
 		DPRINTK("request check condition\n");
 
-		cmd->result = SAM_STAT_CHECK_CONDITION;
+		cmd->result = (DRIVER_SENSE << 24) | SAM_STAT_CHECK_CONDITION;
 
 		qc->scsidone(cmd);
 
@@ -1630,7 +1706,7 @@
 
 		case INQUIRY:
 			if (scsicmd[1] & 2)	           /* is CmdDt set?  */
-				ata_bad_cdb(cmd, done);
+				ata_scsi_invalid_field(cmd, done);
 			else if ((scsicmd[1] & 1) == 0)    /* is EVPD clear? */
 				ata_scsi_rbuf_fill(&args, ata_scsiop_inq_std);
 			else if (scsicmd[2] == 0x00)
@@ -1640,7 +1716,7 @@
 			else if (scsicmd[2] == 0x83)
 				ata_scsi_rbuf_fill(&args, ata_scsiop_inq_83);
 			else
-				ata_bad_cdb(cmd, done);
+				ata_scsi_invalid_field(cmd, done);
 			break;
 
 		case MODE_SENSE:
@@ -1650,7 +1726,7 @@
 
 		case MODE_SELECT:	/* unconditionally return */
 		case MODE_SELECT_10:	/* bad-field-in-cdb */
-			ata_bad_cdb(cmd, done);
+			ata_scsi_invalid_field(cmd, done);
 			break;
 
 		case READ_CAPACITY:
@@ -1661,7 +1737,7 @@
 			if ((scsicmd[1] & 0x1f) == SAI_READ_CAPACITY_16)
 				ata_scsi_rbuf_fill(&args, ata_scsiop_read_cap);
 			else
-				ata_bad_cdb(cmd, done);
+				ata_scsi_invalid_field(cmd, done);
 			break;
 
 		case REPORT_LUNS:
@@ -1673,7 +1749,9 @@
 
 		/* all other commands */
 		default:
-			ata_bad_scsiop(cmd, done);
+			ata_scsi_set_sense(cmd, ILLEGAL_REQUEST, 0x20, 0x0);
+			/* "Invalid command operation code" */
+			done(cmd);
 			break;
 	}
 }

Re: [PATCH] libata: scsi error handling, lk 2.6.14-rc1

[Brett Russ]

Douglas Gilbert wrote:
> Jeff,
> This is a retransmission (and resync against lk 2.6.14-rc1)
> of a patch that I sent on 2005/8/28 . I haven't seen a reply.
> 
> If it has be applied, then my following patch
> ("[PATCH] libata: ATA Information VPD page, lk 2.6.14-rc1")
> should apply.
> 
> This patch adds more general error processing, typically for
> problems (or an early finish) detected while a
> SCSI command is being processed prior to an ATA
> command being executed.
> 
> Changelog:
>   - add extern ata_scsi_set_sense() to build SCSI
>     sense data and corresponding status
>   - this allows removal of extern ata_scsi_badcmd()
>     and static inline ata_bad_scsiop() and ata_bad_cdb()
>   - change "xlat" functions in libata-scsi so they
>     are responsible for SCSI status and sense data
>     when they return 1. This allows GOOD status or a
>     specialized error to be set.
>   - set DRIVER_SENSE when SAM_STAT_CHECK_CONDITION
>     is flagged in scsi_cmnd::result
>   - yield an error for mode sense requests for saved
>     values [sat-r05]
>   - change recent rw_zero_length patch to do nothing
>     (yield GOOD status) when transfer_length==0 for
>     10 and 16 byte READ and WRITE commands (SBC-2).


Hi Doug,

In March I got a bunch of patches in this same area into libata-dev; I'm 
not sure where they sit now (definitely not in 2.6.14-rc).  Jeff would 
probably know.

See start of thread:
http://lkml.org/lkml/2005/3/17/157

So there would be conflicts if my stuff went forward--a lot of the 
changes are similar.  I think the best bet would be to find the tree 
with my patches and for you to look at it and find problems that you 
solved in this patch that I didn't address.

BR

Re: [PATCH] libata: scsi error handling, lk 2.6.14-rc1

[Jeff Garzik]

Brett Russ wrote:
> In March I got a bunch of patches in this same area into libata-dev; I'm 
> not sure where they sit now (definitely not in 2.6.14-rc).  Jeff would 
> probably know.
> 
> See start of thread:
> http://lkml.org/lkml/2005/3/17/157
> 
> So there would be conflicts if my stuff went forward--a lot of the 
> changes are similar.  I think the best bet would be to find the tree 
> with my patches and for you to look at it and find problems that you 
> solved in this patch that I didn't address.


Embarrassingly, I'm afraid they have probably disappeared into the dust 
of my SATA patch archive.  I completely forget the issues with your 
patches that caused me to not apply them immediately :(

	Jeff

Re: [PATCH] libata: scsi error handling, lk 2.6.14-rc1

[Brett Russ]

Jeff Garzik wrote:
> Embarrassingly, I'm afraid they have probably disappeared into the dust 
> of my SATA patch archive.  I completely forget the issues with your 
> patches that caused me to not apply them immediately :(


Don't be embarrassed; you did apply them:

http://lkml.org/lkml/2005/3/24/331

So if we believe that message, the only job is to find out where they 
live.  :-)

BR

Re: [PATCH] libata: scsi error handling, lk 2.6.14-rc1

[Jeff Garzik]

Brett Russ wrote:
> Jeff Garzik wrote:
> 
>> Embarrassingly, I'm afraid they have probably disappeared into the 
>> dust of my SATA patch archive.  I completely forget the issues with 
>> your patches that caused me to not apply them immediately :(
> 
> 
> 
> Don't be embarrassed; you did apply them:
> 
> http://lkml.org/lkml/2005/3/24/331
> 
> So if we believe that message, the only job is to find out where they 
> live.  :-)

I can't find them, so it looks like they need resending :(

Wait a few days, for me to review Doug's patches, and see if anything is 
left to do after that.

	Jeff