From: Mark Lord <lkml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Joshua Kwan <joshk@triplehelix.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, axboe@suse.de, torvalds@osdl.org,
randy_dunlap <rdunlap@xenotime.net>
Subject: Re: SATA suspend/resume (was Re: [PATCH] updated version of Jens' SATA suspend-to-ram patch)
Date: Sat, 01 Oct 2005 14:24:12 -0400 [thread overview]
Message-ID: <433ED44C.3060805@rtr.ca> (raw)
In-Reply-To: <433B79D8.9080305@pobox.com>
Jeff Garzik wrote:
..
> Ah hah! I found the other SCSI suspend patch:
> http://lwn.net/Articles/97453/
> Anybody (Joshua?) up for reconciling and testing the two?
I just now tried out *only* "the other SCSI suspend patch",
and by itself it hangs on resume. Laptop computer, blank screen,
no serial ports, no printk()s visible.
And there's one minor bug in that patch: it uses GFP_KERNEL to
alloc a buffer, but on resume it really should use GFP_ATOMIC instead,
since the swap device is the same drive we're trying to resume..
> 2) sd should call START STOP UNIT on resume
That's probably why it hangs when used as-is by itself.
I may do some further testing.
Anyone else out there playing with this yet?
next prev parent reply other threads:[~2005-10-01 18:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 16:33 [PATCH] updated version of Jens' SATA suspend-to-ram patch Joshua Kwan
2005-09-23 18:07 ` Jens Axboe
2005-09-23 20:23 ` Linus Torvalds
2005-09-23 20:47 ` Jeff Garzik
2005-09-23 21:11 ` Mark Lord
2005-09-23 21:21 ` Joshua Kwan
2005-09-24 7:07 ` Jens Axboe
2005-09-29 5:21 ` SATA suspend/resume (was Re: [PATCH] updated version of Jens' SATA suspend-to-ram patch) Jeff Garzik
2005-09-29 7:34 ` Christoph Hellwig
2005-09-29 8:11 ` Christoph Hellwig
2005-09-29 20:13 ` Randy.Dunlap
2005-09-29 21:48 ` Randy.Dunlap
2005-10-01 18:24 ` Mark Lord [this message]
2005-10-01 18:39 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2005-09-29 14:26 James.Smart
2005-09-29 15:56 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433ED44C.3060805@rtr.ca \
--to=lkml@rtr.ca \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=joshk@triplehelix.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).