From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2.6.14-rc2 1/2] libata: Marvell spinlock fixes and simplification Date: Wed, 05 Oct 2005 17:18:53 -0400 Message-ID: <4344433D.5090305@pobox.com> References: <20051005210610.EC31826369@lns1058.lss.emc.com> <20051005210842.F366B26369@lns1058.lss.emc.com> <434442D9.5010800@pobox.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010705060208000102020607" Return-path: Received: from mail.dvmed.net ([216.237.124.58]:12764 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1030295AbVJEVS5 (ORCPT ); Wed, 5 Oct 2005 17:18:57 -0400 In-Reply-To: <434442D9.5010800@pobox.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Brett Russ Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Pasi Pirhonen , Michael Madore , Bogdan Costescu , "Mr. Berkley Shands" , Jim Edwards , scott olson , Lars Magne Ingebrigtsen , Evgeny Rodichev This is a multi-part message in MIME format. --------------010705060208000102020607 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Also, I just applied the attached patch, to kill a warning: drivers/scsi/sata_mv.c:471: warning: 'mv_dump_mem' defined but not used Jeff --------------010705060208000102020607 Content-Type: text/plain; name="patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch" diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c --- a/drivers/scsi/sata_mv.c +++ b/drivers/scsi/sata_mv.c @@ -467,9 +467,9 @@ static void mv_stop_dma(struct ata_port } } +#ifdef ATA_DEBUG static void mv_dump_mem(void __iomem *start, unsigned bytes) { -#ifdef ATA_DEBUG int b, w; for (b = 0; b < bytes; ) { DPRINTK("%p: ", start + b); @@ -479,8 +479,9 @@ static void mv_dump_mem(void __iomem *st } printk("\n"); } -#endif } +#endif + static void mv_dump_pci_cfg(struct pci_dev *pdev, unsigned bytes) { #ifdef ATA_DEBUG --------------010705060208000102020607--