Re: [PATCH/RFC 0/4] libata: more CHS follow-up patches

[Jeff Garzik <jgarzik@pobox.com>]

Albert Lee wrote:
> Dear all,
> 
> More CHS follow-up patches:
> 
> patch 1/4: move the initialization of ATA_TFLAG_LBA and ATA_TFLAG_LBA48 
> flags to the SCSI translation functions
> 
> patch 2/4: calculate read/write commands and protocols on the fly

These two patches are OK, but failed to apply, probably due to mailer 
issues.

> [jgarzik@pretzel libata-dev]$ patch -sp1 < /g/tmp/mbox 
> 1 out of 1 hunk FAILED -- saving rejects to file drivers/scsi/libata-core.c.rej
> 7 out of 7 hunks FAILED -- saving rejects to file drivers/scsi/libata-scsi.c.rej


> patch 3/4: support overriding the ata_rwcmd_protocol() function

Your above patches make it easy enough to add this patch at any time.  I 
would rather wait until Alan is actually using the hook in his code.


> patch 4/4: optimize LBA28/LBA48 usage

seems OK, but I would like this to see a lot of testing before getting 
merged.  Once they are mailer-unmunged, I will apply patches #1 and #2 
to 'upstream' branch.  Then I will clone a branch from upstream called 
optimize-lba48, and apply patch #4.

I'm worried, for example, that some hardware may not have been tested 
much in the field with rapid switching between LBA28 and LBA48.

	Jeff