* [PATCH libata-dev-2.6:sil24] sil24: implement tf_read callback
@ 2005-10-06 16:43 Tejun Heo
2005-10-06 17:16 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2005-10-06 16:43 UTC (permalink / raw)
To: Jeff Garzik, linux, efalk; +Cc: linux-ide
Hello, guys.
This patch implements ->tf_read callback for sil24. It didn't use to
be necessary but new ata_gen_fixed_sense now makes use of ->tf_read
callback. This patch is taken from Edward Falk's driver.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -229,6 +229,7 @@ static u8 sil24_check_status(struct ata_
static u8 sil24_check_err(struct ata_port *ap);
static u32 sil24_scr_read(struct ata_port *ap, unsigned sc_reg);
static void sil24_scr_write(struct ata_port *ap, unsigned sc_reg, u32 val);
+static void sil24_tf_read(struct ata_port *ap, struct ata_taskfile *tf);
static void sil24_phy_reset(struct ata_port *ap);
static void sil24_qc_prep(struct ata_queued_cmd *qc);
static int sil24_qc_issue(struct ata_queued_cmd *qc);
@@ -280,6 +281,8 @@ static struct ata_port_operations sil24_
.check_err = sil24_check_err,
.dev_select = ata_noop_dev_select,
+ .tf_read = sil24_tf_read,
+
.phy_reset = sil24_phy_reset,
.qc_prep = sil24_qc_prep,
@@ -372,6 +375,12 @@ static void sil24_scr_write(struct ata_p
}
}
+static void sil24_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+{
+ struct sil24_port_priv *pp = ap->private_data;
+ *tf = pp->tf;
+}
+
static void sil24_phy_reset(struct ata_port *ap)
{
__sata_phy_reset(ap);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH libata-dev-2.6:sil24] sil24: implement tf_read callback
2005-10-06 16:43 [PATCH libata-dev-2.6:sil24] sil24: implement tf_read callback Tejun Heo
@ 2005-10-06 17:16 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-10-06 17:16 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux, efalk, linux-ide
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-10-06 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-06 16:43 [PATCH libata-dev-2.6:sil24] sil24: implement tf_read callback Tejun Heo
2005-10-06 17:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).