Re: libata-passthrough problem.

[James Courtier-Dutton <James@superbug.demon.co.uk>]

Mark Lord wrote:
> Jeff Garzik wrote:
> 
>>
>> ata_tf_init() in include/linux/libata.h.
>>
>> I admit with guilt that I had to search around a bit for it, too :)
> 
> 
> Thanks, Jeff.
> 
> In that case, the bug with passthru is obvious:
> 
> static unsigned int
> ata_scsi_pass_thru(struct ata_queued_cmd *qc, const u8 *scsicmd)
> {
> ...
>         tf->device = scsicmd[13];    <<--- always forces ATA "master" 
> unit 0
> ...
>         tf->device = scsicmd[13];    <<--- always forces ATA "master" 
> unit 0
> ...
> 
> 
> Those lines should each do this instead:
> 
>         tf->device = qc->dev->devno ? (scsicmd[13] |  ATA_DEV1)
>                         : (scsicmd[13] & ~ATA_DEV1);
> 
> I'll see about a patch for that shortly.
> 
> Cheers
> 
> 

Please tell me when you have fixed this, so that I could try it.
Please tell me where the fix will go, git libata-dev or linux-2.6

James