Re: [PATCH 5/5] sil24: make error_intr less verbose

[Jeff Garzik <jgarzik@pobox.com>]

Tejun Heo wrote:
> sil24_error_intr is too verbose.  Shut it up.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> Index: work/drivers/scsi/sata_sil24.c
> ===================================================================
> --- work.orig/drivers/scsi/sata_sil24.c	2005-11-16 17:05:19.000000000 +0900
> +++ work/drivers/scsi/sata_sil24.c	2005-11-16 17:08:05.000000000 +0900
> @@ -678,9 +678,9 @@ static void sil24_error_intr(struct ata_
>  	if (serror)
>  		writel(serror, port + PORT_SERROR);
>  
> -	printk(KERN_ERR DRV_NAME " ata%u: error interrupt on port%d\n"
> -	       "  stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",
> -	       ap->id, ap->port_no, slot_stat, irq_stat, cmd_err, sstatus, serror);
> +	DPRINTK("ata%u: error interrupt on port%d\n"
> +		"  stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",
> +		ap->id, ap->port_no, slot_stat, irq_stat, cmd_err, sstatus, serror);

Mild NAK.

I am grappling with this on AHCI too :)  This is because ATA_ERR is much 
more common on ATAPI, yes?

My preferred change would be

	if ((class != ATA_DEV_ATAPI) ||
	    (sil24_cmd_err > PORT_CERR_SDB))
		printk()

so that truly uncommon errors are always printed, but users logs are not 
spammed.

Another option is to do

	if (ata_ratelimit())
		printk()

Regards,

	Jeff