From: Edward Falk <efalk@google.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <htejun@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/5] sil24: make error_intr less verbose
Date: Wed, 16 Nov 2005 10:35:57 -0800 [thread overview]
Message-ID: <437B7C0D.1030405@google.com> (raw)
In-Reply-To: <437B285C.8020809@pobox.com>
>> - printk(KERN_ERR DRV_NAME " ata%u: error interrupt on port%d\n"
>> - " stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",
>> - ap->id, ap->port_no, slot_stat, irq_stat, cmd_err,
>> sstatus, serror);
>> + DPRINTK("ata%u: error interrupt on port%d\n"
>> + " stat=0x%x irq=0x%x cmd_err=%d sstatus=0x%x serror=0x%x\n",
>> + ap->id, ap->port_no, slot_stat, irq_stat, cmd_err, sstatus,
>> serror);
>
>
> Mild NAK.
Agreed. Bear in mind that it's an extrordinarily exceptional
circumstance for the driver to reach this point. If this happens, then
something has truly gone wrong and the message should be logged.
Note that this point in the driver is *not* reached for an ordinary ATA
errors, but only for the kind of errors that libata can't handle.
-ed falk
next prev parent reply other threads:[~2005-11-16 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 8:09 [PATCH 5/5] sil24: make error_intr less verbose Tejun Heo
2005-11-16 12:38 ` Jeff Garzik
2005-11-16 13:27 ` Tejun Heo
2005-11-16 18:35 ` Edward Falk [this message]
2005-11-17 3:03 ` Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437B7C0D.1030405@google.com \
--to=efalk@google.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).