From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] libata: implement ata_qc_exec_internal() Date: Tue, 29 Nov 2005 12:12:04 +0900 Message-ID: <438BC704.9080604@gmail.com> References: <20051128164201.GA7530@htj.dyndns.org> <5d96567b0511280948t45881bf9x989f27be235b47a1@mail.gmail.com> <438BC618.8070300@gmail.com> <438BC667.4040107@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from zproxy.gmail.com ([64.233.162.202]:8375 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S932345AbVK2DML (ORCPT ); Mon, 28 Nov 2005 22:12:11 -0500 Received: by zproxy.gmail.com with SMTP id 14so1519623nzn for ; Mon, 28 Nov 2005 19:12:10 -0800 (PST) In-Reply-To: <438BC667.4040107@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: "Raz Ben-Jehuda(caro)" , Jeff Garzik , linux-ide@vger.kernel.org Tejun Heo wrote: > Tejun Heo wrote: > >> Raz Ben-Jehuda(caro) wrote: >> >>> does it solve the cpu usage ? >>> >>> On 11/28/05, Tejun Heo wrote: >>> >>>> Each user libata internal commands initializes a qc, issues it, waits >>>> for its completion and checks for errors. This patch factors internal >>>> command execution sequence into ata_qc_exec_internal(). The function >>>> also removes race condition between irq and timeout handling. >>>> >>>> Signed-off-by: Tejun Heo >>>> >> >> Hi, Raz. >> >> It propabably has nothing to do with the cpu usage problem on piix you >> reported. I think you need to post more data to get people on the >> list interested in your problem. The followings may help. >> >> 1. Please report exactly which kernel you're using and more >> information on the hardware will also help. >> >> 2. Don't use raid or any fs on it. Just perform tests on raw /dev/sdx >> devices. Do something like 'time dd if=/dev/sdx of=/dev/zero bs=1M >> count=1024' and report how much user/system time it uses. > > > Oops, count=1024 is way too small. Do something like bs=1M count=1M or > maybe count=10M. I hate myself. I must be on crack or something now. count=1024 should be fine (count=2k or 4k should be fine too). Don't do count=1M or 10M. Sorry guys. :-) -- tejun