From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sata_via VT6421 vendor update
Date: Sun, 11 Dec 2005 23:34:18 -0500 [thread overview]
Message-ID: <439CFDCA.2020902@rtr.ca> (raw)
In-Reply-To: <439CF781.3080400@pobox.com>
Jeff Garzik wrote:
>
> + switch (adev->dma_mode & 0x07) {
> + case 0:
> + cfg_byte = 0xee;
> + break;
> + case 1:
> + cfg_byte = 0xe8;
> + break;
> + case 2:
> + cfg_byte = 0xe6;
> + break;
> + case 3:
> + cfg_byte = 0xe4;
> + break;
> + case 4:
> + cfg_byte = 0xe2;
> + break;
> + case 5:
> + cfg_byte = 0xe1;
> + break;
> + case 6:
> + cfg_byte = 0xe0;
> + break;
> + default:
> + cfg_byte = 0xe0;
> + }
Mmm.. replace all that with this (?):
u8 cfg_bytes[8] = {0xee, 0xe8, 0xe6, 0xe4, 0xe2, 0xe1, 0xe0, 0xe0};
cfg_byte = cfg_bytes[adev->dma_mode & 7];
-ml
next prev parent reply other threads:[~2005-12-12 4:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 4:07 [PATCH] sata_via VT6421 vendor update Jeff Garzik
2005-12-12 4:34 ` Mark Lord [this message]
2005-12-12 4:35 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439CFDCA.2020902@rtr.ca \
--to=liml@rtr.ca \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).