From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED97C4332E for ; Mon, 25 Jan 2021 04:37:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B673F22D04 for ; Mon, 25 Jan 2021 04:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbhAYEhK (ORCPT ); Sun, 24 Jan 2021 23:37:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727025AbhAYEhB (ORCPT ); Sun, 24 Jan 2021 23:37:01 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 833DAC0613ED for ; Sun, 24 Jan 2021 20:36:20 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id c132so8087519pga.3 for ; Sun, 24 Jan 2021 20:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FijkUVA4wtqEzKdrwPNqr5BszwjDE0ObYH72kW/p/Qc=; b=ba/PQSHzp1XMXEYfaF8IHUMMLul1kjomGVtf+iR7PS5f0N91qzg13X0RZJ97PPA0Vh 2RdglhLdiBxokgZLrklGFKw5elkOv9IMkxXL0wir8HcRac0waGN3dSgDWP5u3/F7/Cgi zYenYmfFAphreQtQ6crnNkJJn2bJDNx+iWqrZ9M/3gKEPnNx6sQ/UjR6GyJB8zRxqnDY 8AoCDP3zaCxdj45M0aZ0vmEL3zsal3fLpbCh9fg8FUjTPIm99GyHz5AH1S6u4wgID8kS qSTr2uI9gX38rFZ2+qHIncgSSpsuO7n+wVQHBnvHeHyyCbF6tB6X6fJpGBFJ/5ws39Hs f7Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FijkUVA4wtqEzKdrwPNqr5BszwjDE0ObYH72kW/p/Qc=; b=Dy7IwVM3DrHlT2CQXA3RFKZlgXmhX6pxT3VidacCFKd2W8Re0z1dSZtEDTlkWCS9ou L3hISm1i6o4p0pqsymC0BNKjjKL2q+gHEvlXzIModFIPRA3moc3GbdJDfMIee8uyLc4i AIUQLKskl4plPYlB97qhOIHC2SqH/ta326N2Qz8fZshAWVpRKKblpfaaAhBmTSOwGW+w 1x6Ev0Vl4OkIJqFCl6CYcJg6SrOPe6v2hAo7Q0neaVCoWEYG1G1KLpaSt2UdwOkpHx7t 2sSGqoHU78REjebg5LEbP+strRTYAwLsyxHD40WVD4UCgKm8st7R9PFAjnP0CsuIFMd9 ENoQ== X-Gm-Message-State: AOAM5339tsW8X0OU2Yds+qjhpKFS5JlTdgJFclVt9vF72sFm0iUKDcXb kFF257I9v5qd8BceAbUY73S36rNUkT4wug== X-Google-Smtp-Source: ABdhPJwqMLqKBZAD9FxC+3lNxtWNGWUkaLysCeumNlPXimZYcundbTEt00KrsFB9Hb+bWilXVtUrpA== X-Received: by 2002:a63:d917:: with SMTP id r23mr1043183pgg.126.1611549378270; Sun, 24 Jan 2021 20:36:18 -0800 (PST) Received: from [10.8.2.15] ([185.125.207.232]) by smtp.gmail.com with ESMTPSA id k64sm14947157pfd.75.2021.01.24.20.36.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jan 2021 20:36:17 -0800 (PST) Subject: Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq To: Ulf Hansson , Jens Axboe Cc: Christoph Hellwig , linux-nfs@vger.kernel.org, linux-scsi , "linux-mmc@vger.kernel.org" , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-block , linux-ide@vger.kernel.org, target-devel@vger.kernel.org References: <20210122092824.20971-1-guoqing.jiang@cloud.ionos.com> <20210122092824.20971-3-guoqing.jiang@cloud.ionos.com> From: Guoqing Jiang Message-ID: <439d415f-6aed-7092-a593-0d2d490652d2@cloud.ionos.com> Date: Mon, 25 Jan 2021 05:35:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 1/22/21 10:50, Ulf Hansson wrote: > On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang > wrote: >> >> We can remove 'q' from blk_execute_rq as well after the previous change >> in blk_execute_rq_nowait. >> >> And more importantly it never really was needed to start with given >> that we can trivial derive it from struct request. >> >> Cc: linux-scsi@vger.kernel.org >> Cc: virtualization@lists.linux-foundation.org >> Cc: linux-ide@vger.kernel.org >> Cc: linux-mmc@vger.kernel.org >> Cc: linux-nvme@lists.infradead.org >> Cc: linux-nfs@vger.kernel.org >> Signed-off-by: Guoqing Jiang > > [...] > >> drivers/mmc/core/block.c | 10 +++++----- > > [...] > > From mmc point of view, please add: > > Acked-by: Ulf Hansson > > At the moment I don't think this will conflict with any changes to > mmc, but if that happens let's sort it then... > Thank you! Will resend and add your acked-by. Guoqing