From: Jeff Garzik <jgarzik@pobox.com>
To: Randy Dunlap <randy_d_dunlap@linux.intel.com>
Cc: ide <linux-ide@vger.kernel.org>, axboe <axboe@suse.de>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH/RFC 0/7] SATA ACPI suspend/resume support
Date: Wed, 14 Dec 2005 17:29:02 -0500 [thread overview]
Message-ID: <43A09CAE.8090302@pobox.com> (raw)
In-Reply-To: <20051213161058.594e93e6.randy_d_dunlap@linux.intel.com>
Randy Dunlap wrote:
> This is an update to the SATA suspend/resume patches
> to use ACPI methods (specifically _SDD and _GTF).
> This patch series applies to 2.6.15-rc5-git3.
>
> It boots but needs lots of testing & review/comments,
> as well as adding a call to write taskfiles on
> COMRESET event(s) (at least on async. loss of signal) and
> freeing ata_device->gtf_address on module unload.
>
> The patchset begins with the libata suspend/resume patch from
> Jens Axboe and builds on that.
overall:
* we do need some way of sending BIOS settings to the devices, so I
grudgingly accept this, in concept.
* needs a command line arg that disables ACPI use. libata=noacpi[,
option...] would be my suggestion.
* currently assumes that to_pci_dev(struct device *) is valid for all
cases. so, need some way to limit calling the ATA ACPI functions,
depending on runtime hardware configuration.
* at least one endian bug spotted
next prev parent reply other threads:[~2005-12-14 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 0:10 [PATCH/RFC 0/7] SATA ACPI suspend/resume support Randy Dunlap
2005-12-14 22:29 ` Jeff Garzik [this message]
2005-12-17 22:06 ` Randy.Dunlap
2005-12-15 3:04 ` Mark Lord
2005-12-15 3:31 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2005-12-19 15:18 Jae-hyeon Park
2005-12-20 18:55 ` Randy Dunlap
2005-12-22 12:52 ` Jae-hyeon Park
2005-12-22 18:31 ` Randy Dunlap
2005-12-26 5:10 ` Jae-hyeon Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A09CAE.8090302@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=randy_d_dunlap@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).