From: Jeff Garzik <jgarzik@pobox.com>
To: Randy Dunlap <randy_d_dunlap@linux.intel.com>
Cc: linux-ide@vger.kernel.org, axboe@suse.de, petkov@uni-muenster.de
Subject: Re: [PATCH 7/7] SATA ACPI debug-only output
Date: Wed, 14 Dec 2005 17:42:00 -0500 [thread overview]
Message-ID: <43A09FB8.2070700@pobox.com> (raw)
In-Reply-To: <20051214144243.0bc1b1ac.randy_d_dunlap@linux.intel.com>
Randy Dunlap wrote:
> On Wed, 14 Dec 2005 17:23:58 -0500
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>
>>Randy Dunlap wrote:
>>
>>>From: Randy Dunlap <randy_d_dunlap@linux.intel.com>
>>>
>>>Add some extra debug-only output.
>>>
>>>
>>> status = acpi_get_devices(NULL, get_devices, winfo, NULL);
>>>- if (ACPI_FAILURE(status))
>>>+ if (ACPI_FAILURE(status)) {
>>>+ DEBPRINT("acpi_get_devices failed\n");
>>
>>don't invent your own debugprint, use libata's
>
>
> DPRINTK() is too verbose for me. Would you accept something
> that just does debug printing for probe/discovery/enumeration and
> not on every I/O? then I could use the probe/discovery/enumeration
> level of debug printing.
Dig up the patches from Borislav Petkov on linux-ide that made debug
messages more fine-grained. Then we can specific things on and off at
runtime...
Jeff
next prev parent reply other threads:[~2005-12-14 22:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051213160110.193e3f61.randy_d_dunlap@linux.intel.com>
2005-12-14 0:02 ` [PATCH 1/7] SATA suspend/resume support (Jens) Randy Dunlap
2005-12-14 22:07 ` Jeff Garzik
2005-12-14 22:22 ` Randy Dunlap
2005-12-14 0:04 ` [PATCH 2/7] SATA ACPI make/config Randy Dunlap
2005-12-14 22:07 ` Jeff Garzik
2005-12-14 0:05 ` [PATCH 3/7] SATA ACPI linux/libata.h update Randy Dunlap
2005-12-14 22:08 ` Jeff Garzik
2005-12-14 23:00 ` Randy Dunlap
2005-12-14 0:06 ` [PATCH 4/7] call/invoke SATA ACPI suspend/resume functions Randy Dunlap
2005-12-14 22:11 ` Jeff Garzik
2005-12-14 0:07 ` [PATCH 5/7] SATA ACPI kernel-doc Randy Dunlap
2005-12-14 22:12 ` Jeff Garzik
2005-12-14 0:09 ` [PATCH 6/7] SATA ACPI suspend/resume functions Randy Dunlap
2005-12-14 22:23 ` Jeff Garzik
2005-12-14 0:10 ` [PATCH 7/7] SATA ACPI debug-only output Randy Dunlap
2005-12-14 22:23 ` Jeff Garzik
2005-12-14 22:42 ` Randy Dunlap
2005-12-14 22:42 ` Jeff Garzik [this message]
2005-12-14 23:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A09FB8.2070700@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=petkov@uni-muenster.de \
--cc=randy_d_dunlap@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).