* [PATCH 2/2] libata-dev: filter out noisy ATAPI error messages
@ 2005-12-26 8:48 Albert Lee
0 siblings, 0 replies; only message in thread
From: Albert Lee @ 2005-12-26 8:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux IDE, Doug Maxey
Jeff,
Patch 2/2: Minor patch to filter out noisy ATAPI error messages.
Changes:
- Filter out ATAPI packet command error messages in ata_pio_error()
- Filter out ATAPI packet command error messages in ata_host_intr()
Patch against the libata-dev irq-pio branch
(3d0a59c02303df01848537b3bf938dc11e9a0ded).
For your review, thanks.
Albert
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
======
--- err_mask/drivers/scsi/libata-core.c 2005-12-26 14:59:53.000000000 +0800
+++ noisy_err_msg/drivers/scsi/libata-core.c 2005-12-26 15:06:11.000000000 +0800
@@ -3464,11 +3464,12 @@ static void ata_pio_error(struct ata_por
{
struct ata_queued_cmd *qc;
- printk(KERN_WARNING "ata%u: PIO error\n", ap->id);
-
qc = ata_qc_from_tag(ap, ap->active_tag);
assert(qc != NULL);
+ if (qc->tf.command != ATA_CMD_PACKET)
+ printk(KERN_WARNING "ata%u: PIO error\n", ap->id);
+
/* make sure qc->err_mask is available to
* know what's wrong and recover
*/
@@ -4348,8 +4349,9 @@ fsm_start:
break;
case HSM_ST_ERR:
- printk(KERN_ERR "ata%u: command error, drv_stat 0x%x host_stat 0x%x\n",
- ap->id, status, host_stat);
+ if (qc->tf.command != ATA_CMD_PACKET)
+ printk(KERN_ERR "ata%u: command error, drv_stat 0x%x host_stat 0x%x\n",
+ ap->id, status, host_stat);
/* make sure qc->err_mask is available to
* know what's wrong and recover
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-12-26 8:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-26 8:48 [PATCH 2/2] libata-dev: filter out noisy ATAPI error messages Albert Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).