Re: [PATCH] ide: add dcache flushing after PIO

[Tejun Heo <htejun@gmail.com>]

Russell King wrote:
> On Sat, Jan 07, 2006 at 11:41:53PM +0100, Bartlomiej Zolnierkiewicz wrote:
> 
>>Tejun posted RFC to lkml which got zero replies so I thought
>>that I will apply his patch if it *works*.
> 
> 
> Which appears to have been missed.
> 
> 
>>>>So far there was none and nobody seemed to care to test/comment
>>>>this patch ("works fine" is enough).
>>>
>>>Odd, as demonstrated by the linux-ide archives above I've already
>>>commented on it.
>>
>>OK, we have discussed the way to fix the problem.
>>
>>Still nothing was said whether this patch *actually* works or not.
> 
> 
> That's because I've already suggested that the patch is over-complex
> and I'm waiting for an updated patch.  I'm not going to ask folk to
> test one patch which I know is doing far too much, only to have to
> ask them to test another patch later on.
> 
> IOW, I'm not going to waste folk's time with a patch I know isn't
> suitable.
> 
> 
>>Test original Tejun's patch then.
> 
> 
> I can't - I'm not able to reproduce the problem due to the systems
> I have available to me.
> 
> The way forward is an updated patch - Tejun's original patch updated
> with my comments.  Once that's available, folk can test a patch which
> stands a chance of making it into mainline.
> 
> 
> Let me make my position clear: I don't care about this problem myself
> because I don't see it.  That's why it's hung around since 2.4 times.
> My only involvement here is due to (a) other folk caring about it and
> (b) the lack of knowledge to get it fixed.
> 

Hi, Russel & Bartlomiej.

As the message to the lkml didn't get any replies, I kind of forgot 
about it.  And after Russel's explanation, I don't think my first 
approach is good.  I will make another patch according to what I've 
proposed in the message to lkml.  I'm currently burried under libata EH 
related stuff, but I think (or hope) it will be sorted out in a few days.

So, see you guys in a few days.  Thanks.

-- 
tejun