linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ahci: stop engine during hard reset
@ 2006-01-23  7:31 Tejun Heo
  2006-01-27  4:07 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-01-23  7:31 UTC (permalink / raw)
  To: Jeff Garzik, linux-ide

AHCI spec mandates engine to be stopped during hard resets.

Signed-off-by: Tejun Heo <htejun@gmail.com>

---

Jeff, saner version of stopping engine during AHCI hard reset.

diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index 604c4d1..b378cde 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -504,7 +504,9 @@ static void ahci_phy_reset(struct ata_po
 	struct ata_device *dev = &ap->device[0];
 	u32 new_tmp, tmp;
 
+	ahci_stop_engine(ap);
 	__sata_phy_reset(ap);
+	ahci_start_engine(ap);
 
 	if (ap->flags & ATA_FLAG_PORT_DISABLED)
 		return;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ahci: stop engine during hard reset
  2006-01-23  7:31 [PATCH] ahci: stop engine during hard reset Tejun Heo
@ 2006-01-27  4:07 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-01-27  4:07 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-ide

Tejun Heo wrote:
> AHCI spec mandates engine to be stopped during hard resets.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-27  4:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-23  7:31 [PATCH] ahci: stop engine during hard reset Tejun Heo
2006-01-27  4:07 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).