From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>, Doug Maxey <dwm@maxeymade.com>
Subject: [PATCH 2/4] libata-dev: Use new ata_queue_pio_task() for PIO polling task
Date: Wed, 08 Feb 2006 16:48:49 +0800 [thread overview]
Message-ID: <43E9B071.6070000@tw.ibm.com> (raw)
In-Reply-To: <43E9AD00.8070900@tw.ibm.com>
Patch 2/4:
Changes:
- Use new ata_queue_pio_task() for PIO polling task.
- Remove the unused ata_queue_packet_task() function.
(irq-pio had merged the 2 queues into one.)
For your review, thanks.
Albert
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
===
--- rwcmd/drivers/scsi/libata-core.c 2006-02-08 13:39:34.000000000 +0800
+++ queuework/drivers/scsi/libata-core.c 2006-02-08 14:06:41.000000000 +0800
@@ -1073,12 +1073,6 @@ static unsigned int ata_pio_modes(const
}
static inline void
-ata_queue_packet_task(struct ata_port *ap)
-{
- queue_work(ata_wq, &ap->packet_task);
-}
-
-static inline void
ata_queue_pio_task(struct ata_port *ap)
{
queue_work(ata_wq, &ap->pio_task);
@@ -3971,7 +3965,7 @@ unsigned int ata_qc_issue_prot(struct at
ap->hsm_task_state = HSM_ST_LAST;
if (qc->tf.flags & ATA_TFLAG_POLLING)
- queue_work(ata_wq, &ap->pio_task);
+ ata_queue_pio_task(ap);
break;
@@ -4024,7 +4018,7 @@ unsigned int ata_qc_issue_prot(struct at
/* send cdb by polling if no cdb interrupt */
if ((!(qc->dev->flags & ATA_DFLAG_CDB_INTR)) ||
(qc->tf.flags & ATA_TFLAG_POLLING))
- ata_queue_packet_task(ap);
+ ata_queue_pio_task(ap);
break;
case ATA_PROT_ATAPI_DMA:
@@ -4036,7 +4030,7 @@ unsigned int ata_qc_issue_prot(struct at
/* send cdb by polling if no cdb interrupt */
if (!(qc->dev->flags & ATA_DFLAG_CDB_INTR))
- ata_queue_packet_task(ap);
+ ata_queue_pio_task(ap);
break;
default:
next prev parent reply other threads:[~2006-02-08 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 14:23 irq-pio branch updated with Tejun's patches Jeff Garzik
2006-02-08 8:25 ` Albert Lee
2006-02-08 8:34 ` [PATCH 0/4] libata-dev: minor fix for irq-pio with Tejun's EH patches Albert Lee
2006-02-08 8:37 ` [PATCH 1/4] libata-dev: Fix array index value in ata_rwcmd_protocol() Albert Lee
2006-02-09 9:26 ` Jeff Garzik
2006-02-08 8:48 ` Albert Lee [this message]
2006-02-08 8:50 ` [PATCH 3/4] libata-dev: Use new AC_ERR_* flags Albert Lee
2006-02-08 8:51 ` [PATCH 4/4] libata-dev: Minor comment fix Albert Lee
2006-02-08 8:46 ` irq-pio branch updated with Tejun's patches Tejun Heo
2006-02-09 3:23 ` Albert Lee
2006-02-09 3:58 ` Tejun Heo
2006-02-09 9:21 ` Jeff Garzik
2006-02-09 9:31 ` Tejun
2006-02-09 9:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E9B071.6070000@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=dwm@maxeymade.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).