From: Jeff Garzik <jgarzik@pobox.com>
To: brking@us.ibm.com
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 09/15] libata: Improved ata_exec_internal timeout handling
Date: Thu, 09 Feb 2006 02:21:21 -0500 [thread overview]
Message-ID: <43EAED71.5080405@pobox.com> (raw)
In-Reply-To: <200602061542.k16FgYf0002182@d01av01.pok.ibm.com>
brking@us.ibm.com wrote:
> Currently ata_exec_internal does very minimal cleanup if
> the executing command times out. This works for most usage
> scenarios, but can cause problems for hosts that set
> ATA_FLAG_PIO_DMA. For these users, the DMA buffer gets unmapped
> while the timed out out command is still active, which has
> the potential to cause PCI DMA errors if the command is
> still in progress. The following patch modifies ata_exec_internal
> to invoke eng_timeout on a timeout to allow for the timed out
> command to be cleaned up better before proceeding further.
> This patch is also in preparation for SAS attached SATA devices.
>
> Signed-off-by: Brian King <brking@us.ibm.com>
Really this sort of thing is definitely changing an area that Tejun is
also changing pretty heavily...
Jeff
prev parent reply other threads:[~2006-02-09 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-06 15:42 [patch 09/15] libata: Improved ata_exec_internal timeout handling brking
2006-02-08 11:16 ` Tejun Heo
2006-02-08 17:07 ` Brian King
2006-02-08 17:21 ` Tejun
2006-02-11 10:56 ` Tejun Heo
2006-02-09 7:21 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EAED71.5080405@pobox.com \
--to=jgarzik@pobox.com \
--cc=brking@us.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).