* libata janitor project
@ 2006-02-10 11:54 Jeff Garzik
[not found] ` <loom.20060210T132349-817@post.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2006-02-10 11:54 UTC (permalink / raw)
To: linux-ide@vger.kernel.org; +Cc: Linux Kernel
Long term, we should work to replace the assert() in libata with
standard kernel WARN_ON().
If someone wanted to handle that conversion, that would be useful. Make
sure to pay attention, the sense of each test must be reversed.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread[parent not found: <loom.20060210T132349-817@post.gmane.org>]
* Re: libata janitor project [not found] ` <loom.20060210T132349-817@post.gmane.org> @ 2006-02-10 12:46 ` Jeff Garzik 0 siblings, 0 replies; 2+ messages in thread From: Jeff Garzik @ 2006-02-10 12:46 UTC (permalink / raw) To: Philippe Seewer; +Cc: linux-kernel, linux-ide@vger.kernel.org Philippe Seewer wrote: > Jeff Garzik <jgarzik <at> pobox.com> writes: (please don't cut CC's, particularly linux-ide) >>Long term, we should work to replace the assert() in libata with >>standard kernel WARN_ON(). >> >>If someone wanted to handle that conversion, that would be useful. Make >>sure to pay attention, the sense of each test must be reversed. >> >> Jeff >> >>- >>To unsubscribe from this list: send the line "unsubscribe linux-ide" in >>the body of a message to majordomo <at> vger.kernel.org >>More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > > > Just so stupid little me understands this: > replace for example: > assert(sg != NULL) > with > WARN_ON(sg == NULL) > > right? Correct. > ...What about WARN_ON being defined bu HAVE_ARCH_BUG_ON and assert by ATA_DEBUG? I would rather just unconditionally use WARN_ON(), and eliminate assert(). Jeff ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-10 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-10 11:54 libata janitor project Jeff Garzik
[not found] ` <loom.20060210T132349-817@post.gmane.org>
2006-02-10 12:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).