From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] libata: various fixes related to EH, take #4
Date: Fri, 10 Feb 2006 21:16:45 +0900 [thread overview]
Message-ID: <43EC842D.2070601@gmail.com> (raw)
In-Reply-To: <43EC8077.4080003@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>
>> Hello, Jeff.
>>
>> This patchset is the fourth take of 'various fixes related to EH'
>> patchset. From the previous take[1], %01 and %02 made into the tree
>> and %03 got nacked and #04 acked but didn't make into the tree due to
>> dependency to %03. (% denotes patch numbers in the previous take, #
>> in this take)
>
>
> Applied all four patches to 'upstream', but with comments:
>
> * Given your current implementation, ata_qc_complete() should be inline,
> defined in a header somewhere. And __ata_qc_complete() should be
> un-inlined.
Will submit a patch ASAP.
> * Is ATA_FLAG_IN_EH needed in future patches? It's not used ATM.
I don't know it depends on how we'll do EH <-> irq/pio synchronization,
but my bet is on ATA_FLAG_IN_EH being used.
Thanks.
--
tejun
next prev parent reply other threads:[~2006-02-10 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 6:10 [PATCHSET] libata: various fixes related to EH, take #4 Tejun Heo
2006-02-10 6:10 ` [PATCH 1/4] libata: add ATA_QCFLAG_EH_SCHEDULED Tejun Heo
2006-02-10 6:10 ` [PATCH 3/4] libata: use ata_scsi_timed_out() Tejun Heo
2006-02-10 6:10 ` [PATCH 2/4] libata: implement ata_scsi_timed_out() Tejun Heo
2006-02-10 6:10 ` [PATCH 4/4] libata: kill NULL qc handling from ->eng_timeout callbacks Tejun Heo
2006-02-10 12:00 ` [PATCHSET] libata: various fixes related to EH, take #4 Jeff Garzik
2006-02-10 12:16 ` Tejun Heo [this message]
2006-02-11 6:13 ` [PATCH] libata: inline ata_qc_complete() Tejun Heo
2006-02-11 22:53 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-02-10 14:58 [PATCHSET] libata: various fixes related to EH, take #4 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EC842D.2070601@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).