From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/3] libata: convert assert(X)'s in libata core layer to WARN_ON(!X)'s
Date: Sat, 11 Feb 2006 17:54:03 -0500 [thread overview]
Message-ID: <43EE6B0B.1000600@pobox.com> (raw)
In-Reply-To: <1139652673362-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> In an effort to kill libata-specific assert() and use generic
> WARN_ON(), this patch converts all assert(X)'s in libata core layer to
> WARN_ON(!X)'s. Most conversions are straight-forward logical negation
> exception for the followings.
>
> * In libata-core.c:ata_fill_sg(),
> assert(qc->n_elem > 0) is converted to WARN_ON(qc->n_elem == 0) because
> qc->n_elem is unsigned and unsigned <= 0 is weird.
>
> * In libata-scsi.c:ata_gen_ata_desc/fixed_sense(),
> assert(NULL != qc->ap->ops->tf_read) is converted to
> WARN_ON(qc->ap->ops->tf_read == NULL), as there are no other users of
> 'constant cond var' style in libata.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied 1-3
next prev parent reply other threads:[~2006-02-11 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 10:11 [PATCHSET] libata: kill assert Tejun Heo
2006-02-11 10:11 ` [PATCH 1/3] libata: convert assert(X)'s in libata core layer to WARN_ON(!X)'s Tejun Heo
2006-02-11 22:54 ` Jeff Garzik [this message]
2006-02-11 10:11 ` [PATCH 3/3] libata: kill assert() macro Tejun Heo
2006-02-11 10:11 ` [PATCH 2/3] libata: convert assert(xxx)'s in low-level drivers to WARN_ON(!xxx)'s Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EE6B0B.1000600@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).