* [PATCH] libata: don't do EDD handling if ->probe_reset is used
@ 2006-02-12 14:22 Tejun Heo
2006-02-12 19:29 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-02-12 14:22 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
EDD is never used with ->probe_reset. Don't handle EDD special case
in ata_dev_identify if ->probe_reset is in use.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
This patch should have been included in the reset patchset but was
left out somehow, sorry. This patch is generated on top of "misc
preps for configuration reorganization" patchset[1] I've just posted
but also applies over upstream with offset.
[1] http://article.gmane.org/gmane.linux.ide/7977
libata-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: work1/drivers/scsi/libata-core.c
===================================================================
--- work1.orig/drivers/scsi/libata-core.c 2006-02-12 22:54:42.000000000 +0900
+++ work1/drivers/scsi/libata-core.c 2006-02-12 22:56:29.000000000 +0900
@@ -939,7 +939,8 @@ static void ata_dev_identify(struct ata_
return;
}
- if (ap->flags & (ATA_FLAG_SRST | ATA_FLAG_SATA_RESET))
+ if (ap->ops->probe_reset ||
+ ap->flags & (ATA_FLAG_SRST | ATA_FLAG_SATA_RESET))
using_edd = 0;
else
using_edd = 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-12 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-12 14:22 [PATCH] libata: don't do EDD handling if ->probe_reset is used Tejun Heo
2006-02-12 19:29 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).